Sign upLogin

springhackathon/harmox-user

View on GitHub
Star

Showing 4 of 4 total issues

Method callback has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def callback
    request_token = OAuth::RequestToken.new(oauth_consumer, session[:request_token], session[:request_token_secret])

    # OAuthで渡されたtoken, verifierを使って、tokenとtoken_secretを取得
    access_token = nil
Severity: Minor
Found in app/controllers/bot/bot_omniauth_callbacks_controller.rb - About 1 hr to fix

    Method twitter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def twitter
    # You need to implement the method below in your model (e.g. app/models/user.rb)
    @user = User.from_omniauth(request.env["omniauth.auth"])

    if @user.persisted?
    Severity: Minor
    Found in app/controllers/omniauth_callbacks_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_destroy_bot has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def find_destroy_bot
      Bot.find_by_id(params[:id]).tap do |bot|
        bot.twitter_id = bot.twitter_id.blank? ? Controllers::Bot::NG : bot.twitter_id
        bot.twitter_name = bot.twitter_name.blank? ? Controllers::Bot::NG : bot.twitter_name
        bot.access_token = bot.access_token.blank? ? Controllers::Bot::NG : bot.access_token
    Severity: Minor
    Found in app/controllers/bot/bots_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method register_hashtags has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def register_hashtags(hash_tag_ids)
      if hash_tag_ids.nil?
        return true #変更なし
      end
    Severity: Minor
    Found in app/controllers/bot/bots_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language