Sign upLogin

spritejs/sprite-core

View on GitHub
Star
src/core/basenode.js

Summary

Maintainability
D
2 days
Test Coverage

File basenode.js has 447 lines of code (exceeds 350 allowed). Consider refactoring.
Open

// import stylesheet from './stylesheet';
import NodeAttr from './attr';
import {inheritAttributes, parseFont} from '../utils';

function createAttribute(attr, key) {
Severity: Minor
Found in src/core/basenode.js - About 4 hrs to fix

    Function dispatchEvent has 82 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      dispatchEvent(type, evt, collisionState = false, swallow = false, useCapturePhase = null) { // eslint-disable-line complexity
    let handlers = this.getEventHandlers(type);
    if(this.children && useCapturePhase === true) handlers = handlers.filter(handler => handler.useCapture);
    if(this.children && useCapturePhase === false) handlers = handlers.filter(handler => !handler.useCapture);
    evt.returnValue = true;
    Severity: Major
    Found in src/core/basenode.js - About 2 hrs to fix

      Function dispatchEvent has a Cognitive Complexity of 33 (exceeds 25 allowed). Consider refactoring.
      Open

        dispatchEvent(type, evt, collisionState = false, swallow = false, useCapturePhase = null) { // eslint-disable-line complexity
    let handlers = this.getEventHandlers(type);
    if(this.children && useCapturePhase === true) handlers = handlers.filter(handler => handler.useCapture);
    if(this.children && useCapturePhase === false) handlers = handlers.filter(handler => !handler.useCapture);
    evt.returnValue = true;
      Severity: Minor
      Found in src/core/basenode.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

            if((key === 'font'
        || key === 'lineHeight'
        || key === 'lineBreak'
        || key === 'wordBreak'
        || key === 'letterSpacing'
      Severity: Major
      Found in src/core/basenode.js - About 1 hr to fix

        Function attr has a Cognitive Complexity of 29 (exceeds 25 allowed). Consider refactoring.
        Open

          attr(props, val) {
    const setVal = (key, value) => {
      if(!(key in this[_attr])) {
        createAttribute(this[_attr], key);
      }
        Severity: Minor
        Found in src/core/basenode.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                    if(node.querySelectorAll) {
              const nodes = node.querySelectorAll('*');
              nodes.forEach(child => child.restyle());
            }
        Severity: Major
        Found in src/core/basenode.js - About 45 mins to fix

          Consider simplifying this complex logical expression.
          Open

                if(key === 'fontSize'
        || key === 'fontFamily'
        || key === 'fontStyle'
        || key === 'fontVariant'
        || key === 'fontWeight') {
          Severity: Major
          Found in src/core/basenode.js - About 40 mins to fix

            Avoid too many return statements within this function.
            Open

                return this[_data];
            Severity: Major
            Found in src/core/basenode.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return this;
              Severity: Major
              Found in src/core/basenode.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return this[_attr][props];
                Severity: Major
                Found in src/core/basenode.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return this[_attr].attrs;
                  Severity: Major
                  Found in src/core/basenode.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if(typeof props === 'object') {
      Object.entries(props).forEach(([prop, value]) => {
        this.attr(prop, value);
      });
      return this;
                    Severity: Major
                    Found in src/core/basenode.js and 1 other location - About 1 hr to fix
                    src/core/basenode.js on lines 232..237

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if(typeof props === 'object') {
      Object.entries(props).forEach(([prop, value]) => {
        this.data(prop, value);
      });
      return this;
                    Severity: Major
                    Found in src/core/basenode.js and 1 other location - About 1 hr to fix
                    src/core/basenode.js on lines 128..133

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if(val && typeof val.then === 'function') {
          return val.then((res) => {
            setVal(props, res);
          });
        }
                    Severity: Minor
                    Found in src/core/basenode.js and 1 other location - About 35 mins to fix
                    src/core/basenode.js on lines 156..160

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if(val && typeof val.then === 'function') {
          return val.then((res) => {
            setVal(props, res);
          });
        }
                    Severity: Minor
                    Found in src/core/basenode.js and 1 other location - About 35 mins to fix
                    src/core/basenode.js on lines 242..246

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status