Sign upLogin

sprity/sprity

View on GitHub
Star

Showing 16 of 16 total issues

Function transform has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

var transform = function (opt) {
  return function (obj, enc, cb) {
    var stream = this;
    if (obj instanceof Error) {
      cb(obj);
Severity: Minor
Found in lib/to-vinyl.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addTile has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

var addTile = function (opt) {
  return function (tile, enc, cb) {
    if (tile instanceof Error) {
      cb(tile);
    }
Severity: Minor
Found in lib/layout.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTileObj has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

var createTileObj = function (image, opt) {
  return function (stats) {
    if (stats.isFile()) {
      var info = imageinfo(image.contents);
      if (info) {
Severity: Minor
Found in lib/tile.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTileObj has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var createTileObj = function (image, opt) {
  return function (stats) {
    if (stats.isFile()) {
      var info = imageinfo(image.contents);
      if (info) {
Severity: Minor
Found in lib/tile.js - About 1 hr to fix

    Function transform has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var transform = function (opt) {
  return function (obj, enc, cb) {
    var stream = this;
    if (obj instanceof Error) {
      cb(obj);
    Severity: Minor
    Found in lib/to-vinyl.js - About 1 hr to fix

      Function createStyle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var createStyle = function (opt) {
  return function (cb) {
    var stream = this, style;

    if (opt.style) {
      Severity: Minor
      Found in lib/style.js - About 1 hr to fix

        Function src has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          src: function (o) {
    if (!o.src) {
      throw new Error('src dir missing');
    }
        Severity: Minor
        Found in index.js - About 1 hr to fix

          Function createSprite has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var createSprite = function (dim, layout, opt, base) {
  var image;
  var name = getName(dim, layout.name === 'default' ? opt.name : opt.name + '-' + layout.name);
  if (!base) {
    image = renderSprite(layout, dim.ratio, opt);
          Severity: Minor
          Found in lib/sprite.js - About 1 hr to fix

            Function createSprites has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var createSprites = function (opt) {
  return function (layout, enc, cb) {
    if (layout instanceof Error) {
      cb(layout);
    }
            Severity: Minor
            Found in lib/sprite.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                try {
    if (_.isString(opt.processor)) {
      processor = moduleRequire(opt.processor);
    }
    else {
              Severity: Minor
              Found in lib/style.js and 1 other location - About 55 mins to fix
              lib/sprite.js on lines 148..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                try {
    if (_.isString(opt.engine)) {
      engine = moduleRequire(opt.engine);
    }
    else {
              Severity: Minor
              Found in lib/sprite.js and 1 other location - About 55 mins to fix
              lib/style.js on lines 63..80

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function createStyle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              var createStyle = function (opt) {
  return function (cb) {
    var stream = this, style;

    if (opt.style) {
              Severity: Minor
              Found in lib/style.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function createSprites has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              var createSprites = function (opt) {
  return function (layout, enc, cb) {
    if (layout instanceof Error) {
      cb(layout);
    }
              Severity: Minor
              Found in lib/sprite.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function beautify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              var beautify = function (opt) {
  return Promise.method(function (style) {
    if (!opt.template && processor.isBeautifyable(opt)) {
      return prettydiff.api({
        source: style,
              Severity: Minor
              Found in lib/style.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function prepareProcessor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              var prepareProcessor = Promise.method(function (opt) {
  try {
    if (_.isString(opt.processor)) {
      processor = moduleRequire(opt.processor);
    }
              Severity: Minor
              Found in lib/style.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function (opt) {
  log = opt.logger;

  var stream = through2.obj(createSprites(opt));
  try {
              Severity: Minor
              Found in lib/sprite.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language