squirrelphp/entities

View on GitHub
src/RepositoryReadOnly.php

Summary

Maintainability
F
4 days
Test Coverage
A
100%

File RepositoryReadOnly.php has 504 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Squirrel\Entities;

use Squirrel\Connection\LargeObject;
Severity: Major
Found in src/RepositoryReadOnly.php - About 1 day to fix

    Method castOneTableVariable has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function castOneTableVariable(mixed $value, ?string $fieldName = null, bool $isChange = false): int|float|string|LargeObject|null
        {
            // Only scalar values and null are allowed
            if (!\is_null($value) && !\is_scalar($value)) {
                throw Debug::createException(
    Severity: Major
    Found in src/RepositoryReadOnly.php - About 2 hrs to fix

      Function preprocessOrder has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function preprocessOrder(array $orderOptions): array
          {
              // Order SQL parts
              $orderProcessed = [];
      
      
      Severity: Minor
      Found in src/RepositoryReadOnly.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      RepositoryReadOnly has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class RepositoryReadOnly implements RepositoryReadOnlyInterface
      {
          protected array $tableToObjectFields = [];
          protected array $objectToTableFields = [];
          protected array $objectTypes = [];
      Severity: Minor
      Found in src/RepositoryReadOnly.php - About 2 hrs to fix

        Function preprocessWhere has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function preprocessWhere(array $where): array
            {
                // SQL restrictions as an array
                $whereProcessed = [];
        
        
        Severity: Minor
        Found in src/RepositoryReadOnly.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function castOneTableVariable has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function castOneTableVariable(mixed $value, ?string $fieldName = null, bool $isChange = false): int|float|string|LargeObject|null
            {
                // Only scalar values and null are allowed
                if (!\is_null($value) && !\is_scalar($value)) {
                    throw Debug::createException(
        Severity: Minor
        Found in src/RepositoryReadOnly.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepareSelectQueryForLowerLayer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private function prepareSelectQueryForLowerLayer(array $query): array
            {
                // Set the table variable for SQL component
                $query['table'] = $this->config->getTableName();
        
        
        Severity: Minor
        Found in src/RepositoryReadOnly.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method preprocessOrder has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function preprocessOrder(array $orderOptions): array
            {
                // Order SQL parts
                $orderProcessed = [];
        
        
        Severity: Minor
        Found in src/RepositoryReadOnly.php - About 1 hr to fix

          Method prepareSelectQueryForLowerLayer has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function prepareSelectQueryForLowerLayer(array $query): array
              {
                  // Set the table variable for SQL component
                  $query['table'] = $this->config->getTableName();
          
          
          Severity: Minor
          Found in src/RepositoryReadOnly.php - About 1 hr to fix

            Method preprocessWhere has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function preprocessWhere(array $where): array
                {
                    // SQL restrictions as an array
                    $whereProcessed = [];
            
            
            Severity: Minor
            Found in src/RepositoryReadOnly.php - About 1 hr to fix

              Method validateQueryOptions has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function validateQueryOptions(array $validOptions, array $options): array
                  {
                      // One field shortcut - convert to fields array
                      if (isset($validOptions['fields']) && isset($options['field']) && !isset($options['fields'])) {
                          $options['fields'] = [$options['field']];
              Severity: Minor
              Found in src/RepositoryReadOnly.php - About 1 hr to fix

                Function validateQueryOptions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function validateQueryOptions(array $validOptions, array $options): array
                    {
                        // One field shortcut - convert to fields array
                        if (isset($validOptions['fields']) && isset($options['field']) && !isset($options['fields'])) {
                            $options['fields'] = [$options['field']];
                Severity: Minor
                Found in src/RepositoryReadOnly.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function convertResultToObject has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function convertResultToObject(array $tableResult): object
                    {
                        // Only create reflection class once we need it, to be resource efficient
                        if (!isset($this->reflectionClass)) {
                            /**
                Severity: Minor
                Found in src/RepositoryReadOnly.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                                    return Coerce::toFloat($value);
                Severity: Major
                Found in src/RepositoryReadOnly.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return \strval($value);
                  Severity: Major
                  Found in src/RepositoryReadOnly.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return new LargeObject(\strval($value));
                    Severity: Major
                    Found in src/RepositoryReadOnly.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return \boolval($value) === true ? 1 : 0;
                      Severity: Major
                      Found in src/RepositoryReadOnly.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return \intval($value);
                        Severity: Major
                        Found in src/RepositoryReadOnly.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return \floatval($value);
                          Severity: Major
                          Found in src/RepositoryReadOnly.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return Coerce::toString($value);
                            Severity: Major
                            Found in src/RepositoryReadOnly.php - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          if (\strpos($whereName, ':') !== false) {
                                              // Cast variable values
                                              $whereValue = $this->castTableVariable($whereValue);
                              
                                              // Convert all :variable values from object to table notation
                              Severity: Minor
                              Found in src/RepositoryReadOnly.php and 1 other location - About 35 mins to fix
                              src/RepositoryWriteable.php on lines 78..94

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 92.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status