squirrelphp/entities

View on GitHub
src/RepositoryWriteable.php

Summary

Maintainability
C
7 hrs
Test Coverage
A
100%

Function preprocessChanges has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function preprocessChanges(array $changes): array
    {
        // Separate field SQL and field values
        $changesProcessed = [];

Severity: Minor
Found in src/RepositoryWriteable.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insertOrUpdate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function insertOrUpdate(array $fields, array $indexFields = [], ?array $updateFields = null): void
    {
        // Fields after conversion to table notation
        $actualIndexFields = [];

Severity: Minor
Found in src/RepositoryWriteable.php - About 1 hr to fix

    Method preprocessChanges has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function preprocessChanges(array $changes): array
        {
            // Separate field SQL and field values
            $changesProcessed = [];
    
    
    Severity: Minor
    Found in src/RepositoryWriteable.php - About 1 hr to fix

      Method insert has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function insert(array $fields, bool $returnInsertId = false): ?string
          {
              // Make sure we have an autoincrement field if one is requested
              if ($returnInsertId === true && \strlen($this->config->getAutoincrementField()) === 0) {
                  throw Debug::createException(
      Severity: Minor
      Found in src/RepositoryWriteable.php - About 1 hr to fix

        Function insertOrUpdate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function insertOrUpdate(array $fields, array $indexFields = [], ?array $updateFields = null): void
            {
                // Fields after conversion to table notation
                $actualIndexFields = [];
        
        
        Severity: Minor
        Found in src/RepositoryWriteable.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else { // Variables are contained in SQL
                        // Cast change values - can be scalar or array
                        $fieldValue = $this->castTableVariable($fieldValue);
        
                        // Convert all :variable: values from object to table notation
        Severity: Minor
        Found in src/RepositoryWriteable.php and 1 other location - About 35 mins to fix
        src/RepositoryReadOnly.php on lines 458..480

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status