squirrly/squirrly-seo

View on GitHub
controllers/SQ_PostsList.php

Summary

Maintainability
D
2 days
Test Coverage

Method action has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function action() {

        parent::action();

        switch (SQ_Tools::getValue('action')) {
Severity: Major
Found in controllers/SQ_PostsList.php - About 3 hrs to fix

    Function action has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public function action() {
    
            parent::action();
    
            switch (SQ_Tools::getValue('action')) {
    Severity: Minor
    Found in controllers/SQ_PostsList.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_row has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        function add_row($column, $post_id) {
            $title = '';
            $description = '';
            $frontend = null;
            $cached = false;
    Severity: Minor
    Found in controllers/SQ_PostsList.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hookInit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        function hookInit() {
            $browser = SQ_Tools::getBrowserInfo();
    
            if ($browser['name'] == 'IE' && (int) $browser['version'] < 9 && (int) $browser['version'] > 0)
                return;
    Severity: Minor
    Found in controllers/SQ_PostsList.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_row has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function add_row($column, $post_id) {
            $title = '';
            $description = '';
            $frontend = null;
            $cached = false;
    Severity: Minor
    Found in controllers/SQ_PostsList.php - About 1 hr to fix

      Function insert has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          function insert($src, $in, $pos) {
              if (is_int($pos))
                  $array = array_merge(array_slice($src, 0, $pos), $in, array_slice($src, $pos));
              else {
                  foreach ($src as $k => $v) {
      Severity: Minor
      Found in controllers/SQ_PostsList.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              echo '<script type="text/javascript">
                          var __sq_article_rank = "' . __('Squirrly article rank', _PLUGIN_NAME_) . '";
                          var __sq_refresh = "' . __('Update', _PLUGIN_NAME_) . '"
                          var __sq_more_details = "' . __('More details', _PLUGIN_NAME_) . '";
                          var __sq_less_details = "' . __('Less details', _PLUGIN_NAME_) . '";
      Severity: Major
      Found in controllers/SQ_PostsList.php and 1 other location - About 1 day to fix
      core/SQ_Blocksearch/SQ_Blocksearch.php on lines 49..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 296.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          function getPaged($link) {
              $page = get_query_var('paged');
              if ($page && $page > 1) {
                  $link = trailingslashit($link) . "page/" . "$page";
                  if ($has_ut) {
      Severity: Major
      Found in controllers/SQ_PostsList.php and 2 other locations - About 40 mins to fix
      controllers/SQ_Post.php on lines 201..212
      models/SQ_Frontend.php on lines 1089..1100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status