squirrly/squirrly-seo

View on GitHub

Showing 200 of 200 total issues

File SQ_Frontend.php has 882 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Model_SQ_Frontend {

    /** @var string */
Severity: Major
Found in models/SQ_Frontend.php - About 2 days to fix

    Function __construct has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
    Open

        function __construct($image, $newfile) {
            $ret = "";
    
            $ret.= $this->jpexs_inttoword(0); //PASSWORD
            $ret.=$this->jpexs_inttoword(1); //SOURCE
    Severity: Minor
    Found in models/SQ_Menu.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateSitemap has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
    Open

        public function generateSitemap() {
            global $wpdb, $wp_query, $wp_version;
            /* get the home url */
            $home = get_bloginfo('url');
            $homeID = 0;
    Severity: Minor
    Found in classes/SQ_Sitemap.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function grabKeywordsFromPost has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring.
    Open

        private function grabKeywordsFromPost($id = null) {
            global $wp_query;
    
            $this->max_keywrods = ($this->max_keywrods > 0 ? ($this->max_keywrods - 1) : 0);
            if ($this->max_keywrods == 0)
    Severity: Minor
    Found in models/SQ_Frontend.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function addMenu($param = null) {
            if ($param)
                $this->menu = $param;
    
            if (is_array($this->menu)) {
    Severity: Major
    Found in models/SQ_Menu.php and 1 other location - About 1 day to fix
    models/SQ_Menu.php on lines 72..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 306.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function addSubmenu($param = null) {
            if ($param)
                $this->menu = $param;
    
            if (is_array($this->menu)) {
    Severity: Major
    Found in models/SQ_Menu.php and 1 other location - About 1 day to fix
    models/SQ_Menu.php on lines 41..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 306.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            echo '<script type="text/javascript">
                        var __sq_article_rank = "' . __('Squirrly article rank', _PLUGIN_NAME_) . '";
                        var __sq_refresh = "' . __('Update', _PLUGIN_NAME_) . '"
                        var __sq_more_details = "' . __('More details', _PLUGIN_NAME_) . '";
                        var __sq_less_details = "' . __('Less details', _PLUGIN_NAME_) . '";
    Severity: Major
    Found in controllers/SQ_PostsList.php and 1 other location - About 1 day to fix
    core/SQ_Blocksearch/SQ_Blocksearch.php on lines 49..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 296.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            echo '<script type="text/javascript">
                 var __date = "' . __('date', _PLUGIN_NAME_) . '"; var __readit = "' . __('Read it!', _PLUGIN_NAME_) . '"; var __insertit = "' . __('Insert it!', _PLUGIN_NAME_) . '"; var __reference = "' . __('Reference', _PLUGIN_NAME_) . '"; var __insertasbox = "' . __('Insert as box', _PLUGIN_NAME_) . '"; var __notrelevant = "' . __('Not relevant?', _PLUGIN_NAME_) . '"; var __insertparagraph = "' . __('Insert in your article', _PLUGIN_NAME_) . '"; var __tinymceerror = "' . __('For Squirrly to work, you have to have tinymce editor installed!', _PLUGIN_NAME_) . '"; var __ajaxerror = "' . __(':( I lost my squirrel. Please reload the page.', _PLUGIN_NAME_) . '"; var __nofound = "' . __('No results found!', _PLUGIN_NAME_) . '"; var __tinymceinactive = "' . __('Switch to Visual editor!', _PLUGIN_NAME_) . '"; var __morewords = "' . __('Use more words in one keyword', _PLUGIN_NAME_) . '"; var __toolong = "' . __('Takes too long to check this keyword ...', _PLUGIN_NAME_) . '"; var __doresearch = "' . __('Do a research!', _PLUGIN_NAME_) . '"; var __morekeywords = "' . __('Do more research!', _PLUGIN_NAME_) . '"; var __sq_photo_copyright = "' . __('[ ATTRIBUTE: Please check: %s to find out how to attribute this image ]', _PLUGIN_NAME_) . '"; var __has_attributes = "' . __('Has creative commons attributes', _PLUGIN_NAME_) . '"; var __no_attributes = "' . __('No known copyright restrictions', _PLUGIN_NAME_) . '";
    Severity: Major
    Found in core/SQ_Blocksearch/SQ_Blocksearch.php and 1 other location - About 1 day to fix
    controllers/SQ_PostsList.php on lines 171..187

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 296.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

               if(typeof response.info != 'undefined'){
                   jQuery('#sq_autologin').hide();
                   jQuery('#sq_blocklogin').find('ul').show();
    
                   jQuery('#sq_blocklogin').find('.sq_message').html(response.info).show();
    Severity: Major
    Found in themes/default/js/sq_blocklogin.js and 1 other location - About 1 day to fix
    themes/default/js/sq_blocklogin.js on lines 150..163

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                        if(typeof response.info != 'undefined'){
                            jQuery('#sq_autologin').hide();
                            jQuery('#sq_blocklogin').find('ul').show();
    
                            jQuery('#sq_blocklogin').find('.sq_message').html(response.info).show();
    Severity: Major
    Found in themes/default/js/sq_blocklogin.js and 1 other location - About 1 day to fix
    themes/default/js/sq_blocklogin.js on lines 128..141

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File SQ_Menu.php has 516 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    class Model_SQ_Menu {
    
        /** @var array with the menu content
    Severity: Major
    Found in models/SQ_Menu.php - About 1 day to fix

      Method __construct has 176 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function __construct($image, $newfile) {
              $ret = "";
      
              $ret.= $this->jpexs_inttoword(0); //PASSWORD
              $ret.=$this->jpexs_inttoword(1); //SOURCE
      Severity: Major
      Found in models/SQ_Menu.php - About 7 hrs to fix

        Model_SQ_Frontend has 48 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Model_SQ_Frontend {
        
            /** @var string */
            private $title;
        
        Severity: Minor
        Found in models/SQ_Frontend.php - About 6 hrs to fix

          Function getActions has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getActions($cur_action) {
          
                  /* if config allready in cache */
                  if (!isset(self::$config)) {
                      $config_file = _SQ_CORE_DIR_ . 'config.xml';
          Severity: Minor
          Found in classes/SQ_Action.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getCanonicalUrl has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
          Open

              function getCanonicalUrl() {
                  global $wp_query;
          
                  if (!isset($wp_query) || $wp_query->is_404 || $wp_query->is_search) {
                      return false;
          Severity: Minor
          Found in models/SQ_Frontend.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkImage has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
          Open

              function checkImage($post_id) {
                  @set_time_limit(90);
                  $local_file = false;
          
                  $content = stripslashes(SQ_Tools::getValue('post_content'));
          Severity: Minor
          Found in controllers/SQ_Post.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method generateSitemap has 144 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function generateSitemap() {
                  global $wpdb, $wp_query, $wp_version;
                  /* get the home url */
                  $home = get_bloginfo('url');
                  $homeID = 0;
          Severity: Major
          Found in classes/SQ_Sitemap.php - About 5 hrs to fix

            Function getBlocks has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getBlocks($for) {
                    /* if config allready in cache */
                    if (!isset(self::$config)) {
                        $config_file = _SQ_CORE_DIR_ . 'config.xml';
                        if (!file_exists($config_file))
            Severity: Minor
            Found in classes/SQ_ObjController.php - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function checkFavebookInsightsCode($code) {
                    if ($code <> '') {
                        if (strpos($code, 'content') !== false) {
                            preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                            if (isset($result[1]) && !empty($result[1]))
            Severity: Major
            Found in models/SQ_Menu.php and 2 other locations - About 5 hrs to fix
            models/SQ_Menu.php on lines 141..159
            models/SQ_Menu.php on lines 219..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 196.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function checkBingWTCode($code) {
                    if ($code <> '') {
                        if (strpos($code, 'content') !== false) {
                            preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                            if (isset($result[1]) && !empty($result[1]))
            Severity: Major
            Found in models/SQ_Menu.php and 2 other locations - About 5 hrs to fix
            models/SQ_Menu.php on lines 141..159
            models/SQ_Menu.php on lines 194..212

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 196.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language