squirrly/squirrly-seo

View on GitHub
models/SQ_Menu.php

Summary

Maintainability
F
1 wk
Test Coverage

Function __construct has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

    function __construct($image, $newfile) {
        $ret = "";

        $ret.= $this->jpexs_inttoword(0); //PASSWORD
        $ret.=$this->jpexs_inttoword(1); //SOURCE
Severity: Minor
Found in models/SQ_Menu.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File SQ_Menu.php has 516 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Model_SQ_Menu {

    /** @var array with the menu content
Severity: Major
Found in models/SQ_Menu.php - About 1 day to fix

    Method __construct has 176 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function __construct($image, $newfile) {
            $ret = "";
    
            $ret.= $this->jpexs_inttoword(0); //PASSWORD
            $ret.=$this->jpexs_inttoword(1); //SOURCE
    Severity: Major
    Found in models/SQ_Menu.php - About 7 hrs to fix

      Function addFavicon has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          public function addFavicon($file, $path = ABSPATH) {
              $out = array();
              $out['name'] = strtolower(basename($file['name']));
              $out['tmp'] = _SQ_CACHE_DIR_ . strtolower(basename($file['name']));
              $out['favicon'] = $path . "/" . 'favicon.ico';
      Severity: Minor
      Found in models/SQ_Menu.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method addFavicon has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function addFavicon($file, $path = ABSPATH) {
              $out = array();
              $out['name'] = strtolower(basename($file['name']));
              $out['tmp'] = _SQ_CACHE_DIR_ . strtolower(basename($file['name']));
              $out['favicon'] = $path . "/" . 'favicon.ico';
      Severity: Major
      Found in models/SQ_Menu.php - About 2 hrs to fix

        Function resizeImage has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            function resizeImage($maxwidth, $maxheight, $preserveAspect = true) {
                $width = @imagesx($this->imgH);
                $height = @imagesy($this->imgH);
        
                if ($width > $maxwidth && $height > $maxheight) {
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addSubmenu has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addSubmenu($param = null) {
                if ($param)
                    $this->menu = $param;
        
                if (is_array($this->menu)) {
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkFavebookInsightsCode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function checkFavebookInsightsCode($code) {
                if ($code <> '') {
                    if (strpos($code, 'content') !== false) {
                        preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                        if (isset($result[1]) && !empty($result[1]))
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkBingWTCode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function checkBingWTCode($code) {
                if ($code <> '') {
                    if (strpos($code, 'content') !== false) {
                        preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                        if (isset($result[1]) && !empty($result[1]))
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkGoogleAnalyticsCode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function checkGoogleAnalyticsCode($code) {
                //echo $code;
                if ($code <> '') {
                    if (strpos($code, '_gaq.push') !== false) {
                        preg_match('/_gaq.push\(\[[\'\"]_setAccount[\'\"],\\s?[\'\"]([^\'\"]+)[\'\"]\]\)/i', $code, $result);
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkGoogleWTCode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function checkGoogleWTCode($code) {
                if ($code <> '') {
                    if (strpos($code, 'content') !== false) {
                        preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                        if (isset($result[1]) && !empty($result[1]))
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addMenu has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addMenu($param = null) {
                if ($param)
                    $this->menu = $param;
        
                if (is_array($this->menu)) {
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addMeta has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addMeta($param = null) {
                if ($param)
                    $this->meta = $param;
        
        
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method resizeImage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function resizeImage($maxwidth, $maxheight, $preserveAspect = true) {
                $width = @imagesx($this->imgH);
                $height = @imagesy($this->imgH);
        
                if ($width > $maxwidth && $height > $maxheight) {
        Severity: Minor
        Found in models/SQ_Menu.php - About 1 hr to fix

          Function openImage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              function openImage($image) {
                  $this->image = $image;
          
                  if (!file_exists($image))
                      return false;
          Severity: Minor
          Found in models/SQ_Menu.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                          return $out;
          Severity: Major
          Found in models/SQ_Menu.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return;
            Severity: Major
            Found in models/SQ_Menu.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return;
              Severity: Major
              Found in models/SQ_Menu.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function addSubmenu($param = null) {
                        if ($param)
                            $this->menu = $param;
                
                        if (is_array($this->menu)) {
                Severity: Major
                Found in models/SQ_Menu.php and 1 other location - About 1 day to fix
                models/SQ_Menu.php on lines 41..63

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 306.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function addMenu($param = null) {
                        if ($param)
                            $this->menu = $param;
                
                        if (is_array($this->menu)) {
                Severity: Major
                Found in models/SQ_Menu.php and 1 other location - About 1 day to fix
                models/SQ_Menu.php on lines 72..94

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 306.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function checkBingWTCode($code) {
                        if ($code <> '') {
                            if (strpos($code, 'content') !== false) {
                                preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                                if (isset($result[1]) && !empty($result[1]))
                Severity: Major
                Found in models/SQ_Menu.php and 2 other locations - About 5 hrs to fix
                models/SQ_Menu.php on lines 141..159
                models/SQ_Menu.php on lines 194..212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 196.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function checkFavebookInsightsCode($code) {
                        if ($code <> '') {
                            if (strpos($code, 'content') !== false) {
                                preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                                if (isset($result[1]) && !empty($result[1]))
                Severity: Major
                Found in models/SQ_Menu.php and 2 other locations - About 5 hrs to fix
                models/SQ_Menu.php on lines 141..159
                models/SQ_Menu.php on lines 219..237

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 196.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function checkGoogleWTCode($code) {
                        if ($code <> '') {
                            if (strpos($code, 'content') !== false) {
                                preg_match('/content\\s*=\\s*[\'\"]([^\'\"]+)[\'\"]/i', $code, $result);
                                if (isset($result[1]) && !empty($result[1]))
                Severity: Major
                Found in models/SQ_Menu.php and 2 other locations - About 5 hrs to fix
                models/SQ_Menu.php on lines 194..212
                models/SQ_Menu.php on lines 219..237

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 196.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status