state-machines/state_machines

View on GitHub

Showing 40 of 40 total issues

Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(owner_class, *args, &block)
      options = args.last.is_a?(Hash) ? args.pop : {}
      options.assert_valid_keys(:attribute, :initial, :initialize, :action, :plural, :namespace, :integration, :messages, :use_transactions)

      # Find an integration that matches this machine's owner class
Severity: Minor
Found in lib/state_machines/machine.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(options = {}) #:nodoc:
      # Build conditionals
      @if_condition = options.delete(:if)
      @unless_condition = options.delete(:unless)

Severity: Minor
Found in lib/state_machines/branch.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method description has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def description(options = {})
      label = options[:human_name] ? human_name : name
      description = label ? label.to_s : label.inspect
      description << " (#{@value.is_a?(Proc) ? '*' : @value.inspect})" unless name.to_s == @value.to_s
      description
Severity: Minor
Found in lib/state_machines/state.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method after has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def after
      unless @after_run
        # First resume previously paused callbacks
        if resume
          catch(:halt) do
Severity: Minor
Found in lib/state_machines/transition.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                pause if @success && !complete
Severity: Major
Found in lib/state_machines/transition.rb - About 45 mins to fix

    Method owner_class_ancestor_has_method? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def owner_class_ancestor_has_method?(scope, method)
          return false unless owner_class_has_method?(scope, method)
    
          superclasses = owner_class.ancestors.select { |ancestor| ancestor.is_a?(Class) }[1..-1]
    
    
    Severity: Minor
    Found in lib/state_machines/machine.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                    throw :cancel, true unless @success
    Severity: Major
    Found in lib/state_machines/transition.rb - About 45 mins to fix

      Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(object, machine, event, from_name, to_name, read_state = true) #:nodoc:
      Severity: Minor
      Found in lib/state_machines/transition.rb - About 45 mins to fix

        Method build_matcher has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def build_matcher(options, whitelist_option, blacklist_option)
              options.assert_exclusive_keys(whitelist_option, blacklist_option)
        
              if options.include?(whitelist_option)
                value = options[whitelist_option]
        Severity: Minor
        Found in lib/state_machines/branch.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method define_helper has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def define_helper(scope, method, *args, **kwargs, &block)
        Severity: Minor
        Found in lib/state_machines/machine.rb - About 35 mins to fix

          Method run_methods has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def run_methods(object, context = {}, index = 0, *args, &block)
          Severity: Minor
          Found in lib/state_machines/callback.rb - About 35 mins to fix

            Method pause has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def pause
                  raise ArgumentError, 'around_transition callbacks cannot be called in multiple execution contexts in java implementations of Ruby. Use before/after_transitions instead.' unless self.class.pause_supported?
            
                  unless @resume_block
                    require 'continuation' unless defined?(callcc)
            Severity: Minor
            Found in lib/state_machines/transition.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method define_event_helpers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def define_event_helpers
                  # Gets the events that are allowed to fire on the current object
                  define_helper(:instance, attribute(:events)) do |machine, object, *args|
                    machine.events.valid_for(object, *args).map { |event| event.name }
                  end
            Severity: Minor
            Found in lib/state_machines/machine.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def initialize(machine, name, options = {}) #:nodoc:
                  options.assert_valid_keys(:human_name)
            
                  @machine = machine
                  @name = name
            Severity: Minor
            Found in lib/state_machines/event.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def initialize_state(object, options = {})
                  state = initial_state(object)
                  if state && (options[:force] || initialize_state?(object))
                    value = state.value
            
            
            Severity: Minor
            Found in lib/state_machines/machine.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method add_states has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def add_states(new_states)
                  new_states.map do |new_state|
                    # Check for other states that use a different class type for their name.
                    # This typically prevents string / symbol misuse.
                    if new_state && (conflict = states.detect { |state| state.name && state.name.class != new_state.class })
            Severity: Minor
            Found in lib/state_machines/machine.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method transition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def transition(options)
                  options.assert_valid_keys(:from, :to, :on, :if, :unless)
                  raise ArgumentError, 'Must specify :on event' unless options[:on]
                  raise ArgumentError, 'Must specify either :to or :from state' unless !options[:to] ^ !options[:from]
            
            
            Severity: Minor
            Found in lib/state_machines/state_context.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method pausable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def pausable
                  begin
                    halted = !catch(:halt) { yield; true }
                  rescue => error
                    raise unless @resume_block
            Severity: Minor
            Found in lib/state_machines/transition.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run_callbacks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def run_callbacks(index = 0, &block)
                  if transition = self[index]
                    throw :halt unless transition.run_callbacks(after: !skip_after) do
                      run_callbacks(index + 1, &block)
                      {result: results[transition.action], success: success?}
            Severity: Minor
            Found in lib/state_machines/transition_collection.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def value(eval = true)
                  if @value.is_a?(Proc) && eval
                    if cache_value?
                      @value = @value.call
                      machine.states.update(self)
            Severity: Minor
            Found in lib/state_machines/state.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language