Sign upLogin

steroid-team/app

View on GitHub
Star
app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java

Summary

Maintainability
A
1 hr
Test Coverage
B
82%

Method onCreateView has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public View onCreateView(
            @NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        View root = inflater.inflate(R.layout.fragment_note_selection, container, false);
Severity: Minor
Found in app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

        public void renameNote(Note note, final int position) {

        DialogListener dialogListener =
                new DialogListener() {
    Severity: Major
    Found in app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java and 1 other location - About 1 hr to fix
    app/src/main/java/com/github/steroidteam/todolist/view/ListSelectionFragment.java on lines 148..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 85.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private void createNote(View view) {

        DialogListener dialogListener =
                new DialogListener() {
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java and 1 other location - About 1 hr to fix
    app/src/main/java/com/github/steroidteam/todolist/view/ListSelectionFragment.java on lines 95..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

        private NoteArrayListAdapter.NoteHolder.NoteCustomListener createCustomListener() {
        return holder -> {
            viewModel.selectNote(holder.getNote().getId());
            Navigation.findNavController(holder.itemView)
                    .navigate(R.id.nav_note_display, new Bundle());
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java and 1 other location - About 30 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/view/ListSelectionFragment.java on lines 66..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status