stevenhaddox/rvm_fw

View on GitHub
public/javascripts/bootstrap/modal.js

Summary

Maintainability
F
2 wks
Test Coverage

Function show has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Modal.prototype.show = function (_relatedTarget) {
    var that = this
    var e    = $.Event('show.bs.modal', { relatedTarget: _relatedTarget })

    this.$element.trigger(e)
Severity: Minor
Found in public/javascripts/bootstrap/modal.js - About 1 hr to fix

    Function backdrop has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Modal.prototype.backdrop = function (callback) {
        var that = this
        var animate = this.$element.hasClass('fade') ? 'fade' : ''
    
        if (this.isShown && this.options.backdrop) {
    Severity: Minor
    Found in public/javascripts/bootstrap/modal.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      +function ($) {
        'use strict';
      
        // MODAL CLASS DEFINITION
        // ======================
      Severity: Major
      Found in public/javascripts/bootstrap/modal.js and 1 other location - About 2 wks to fix
      public/javascripts/bootstrap.js on lines 912..1241

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 3229.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status