stoplightio/json

View on GitHub

Showing 3 of 3 total issues

Function findNodeAtPath has a Cognitive Complexity of 35 (exceeds 30 allowed). Consider refactoring.
Open

function findNodeAtPath(node: IJsonASTNode, path: JsonPath, closest: boolean): IJsonASTNode | undefined {
  pathLoop: for (const part of path) {
    const segment = Number.isInteger(Number(part)) ? Number(part) : part;
    if (typeof segment === 'string' || (typeof segment === 'number' && node.type !== 'array')) {
      if (node.type !== 'object' || !Array.isArray(node.children)) {
Severity: Minor
Found in src/getLocationForJsonPath.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseTree has a Cognitive Complexity of 33 (exceeds 30 allowed). Consider refactoring.
Open

export function parseTree<T>(
  text: string,
  errors: IDiagnostic[] = [],
  options: IParseOptions,
): IParserASTResult<T, IJsonASTNode, number[]> {
Severity: Minor
Found in src/parseWithPointers.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return true;
Severity: Major
Found in src/startsWith.ts - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language