Sign upLogin

stretchr/objx

View on GitHub
Star

Showing 6 of 39 total issues

Method Map.parseURLValues has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m Map) parseURLValues(queryMap Map, vals url.Values, key string) {
    useSliceIndex := false
    if urlValuesSliceKeySuffix == "[i]" {
        useSliceIndex = true
    }
Severity: Minor
Found in conversions.go - About 1 hr to fix

Function access has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func access(current interface{}, selector string, value interface{}, isSet bool) interface{} {
    thisSel, nextSel := getKey(selector)

    indexes := []int{}
    for strings.Contains(thisSel, "[") {
Severity: Minor
Found in accessors.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function access has 52 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func access(current interface{}, selector string, value interface{}, isSet bool) interface{} {
    thisSel, nextSel := getKey(selector)

    indexes := []int{}
    for strings.Contains(thisSel, "[") {
Severity: Minor
Found in accessors.go - About 1 hr to fix

Method Value.ObjxMapSlice has 5 return statements (exceeds 4 allowed).
Open

func (v *Value) ObjxMapSlice(optionalDefault ...[](Map)) [](Map) {
    if s, ok := v.data.([]Map); ok {
        return s
    }
Severity: Major
Found in type_specific.go - About 35 mins to fix

exported const URLValuesSliceKeySuffixEmpty should have comment (or a comment on this block) or be unexported
Open

    URLValuesSliceKeySuffixEmpty = ""
Severity: Minor
Found in conversions.go by golint

error strings should not be capitalized or end with punctuation or a newline
Open

    return errors.New("objx: Invalid URLValuesSliceKeySuffix provided.")
Severity: Minor
Found in conversions.go by golint
Severity
Category
Status
Source
Language