app/Supports/CrawlerUrl.php
File CrawlerUrl.php
has 291 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
<?php
namespace Suitcoda\Supports;
use GuzzleHttp\Client;
CrawlerUrl
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
Open
class CrawlerUrl
{
/**
* Stores the base url of current crawling session
*
Method doRequest
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function doRequest($url, $try = null)
{
if (is_null($try)) {
$try = $this->retry;
}
Function getAllLink
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function getAllLink($currentUrl, $lists, &$siteLink, $recursive = 0)
{
foreach ($lists as $list) {
if (!$list || !$this->checkIfCrawlable($list)) {
continue;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function doRequest
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
public function doRequest($url, $try = null)
{
if (is_null($try)) {
$try = $this->retry;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return $this->doRequest($url, $try);