superscriptjs/sfacts

View on GitHub

Showing 11 of 11 total issues

Function expand has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const expand = function expand(db, level) {
  const createUserDB = function createUserDB(dbName) {
    // With Hooks
    const sub = levelSublevel(level);
    const graphLevel = sub.sublevel(dbName);
Severity: Major
Found in src/expand.js - About 3 hrs to fix

    Function readTableFile has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const readTableFile = function readTableFile(file, db, callback) {
      const regex = /table:\s*~([a-z_]*)\s*\((.*)\)([\s\S]*?)DATA:((?:(?!table|#)[\s\S])*)/gi;
      let table = regex.exec(file);
      const tables = [];
    
    
    Severity: Minor
    Found in src/concepts.js - About 1 hr to fix

      Function conceptToList has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const conceptToList = function conceptToList(term, depth, cb) {
          if (_.isFunction(depth)) {
            cb = depth;
            depth = 0;
          }
      Severity: Minor
      Found in src/expand.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (filename.slice(-4) === '.top') {
            debug(`Processing concept file: ${filename}`);
            fs.readFile(filename, 'utf8', (err, contents) => {
              if (err) {
                return callback(err);
        Severity: Major
        Found in src/concepts.js and 1 other location - About 1 hr to fix
        src/concepts.js on lines 174..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          } else if (filename.slice(-4) === '.tbl') {
            debug(`Processing table file: ${filename}`);
            fs.readFile(filename, 'utf8', (err, contents) => {
              if (err) {
                return callback(err);
        Severity: Major
        Found in src/concepts.js and 1 other location - About 1 hr to fix
        src/concepts.js on lines 166..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function addFact has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        const addFact = function addFact(c, fact, callback) {
          const p0 = fact[0];
          const p1 = fact[1];
          const p2 = fact[2];
        
        
        Severity: Minor
        Found in src/concepts.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function readConceptFile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const readConceptFile = function readConceptFile(file, db, callback) {
          const regex = /concept:\s*~([a-z_]*).*\(([\s\S]*?)\)/gi;
          let concept = regex.exec(file);
          const concepts = [];
        
        
        Severity: Minor
        Found in src/concepts.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            }, () => {
              c.tables = _.uniq(c.tables);
              c.referencedConcepts = _.uniq(c.referencedConcepts);
              callback(c);
            });
          Severity: Major
          Found in src/concepts.js and 1 other location - About 1 hr to fix
          src/concepts.js on lines 72..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            }, () => {
              c.highLevelConcepts = _.uniq(c.highLevelConcepts);
              c.referencedConcepts = _.uniq(c.highLevelConcepts);
              callback(c);
            });
          Severity: Major
          Found in src/concepts.js and 1 other location - About 1 hr to fix
          src/concepts.js on lines 158..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function addFact has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const addFact = function addFact(c, fact, callback) {
            const p0 = fact[0];
            const p1 = fact[1];
            const p2 = fact[2];
          
          
          Severity: Minor
          Found in src/concepts.js - About 1 hr to fix

            Function readFile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            const readFile = function readFile(filename, db, callback) {
              if (filename.slice(-4) === '.top') {
                debug(`Processing concept file: ${filename}`);
                fs.readFile(filename, 'utf8', (err, contents) => {
                  if (err) {
            Severity: Minor
            Found in src/concepts.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language