svoop/ogn_client-ruby

View on GitHub

Showing 5 of 7 total issues

Class ReceiverStatus has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ReceiverStatus < Message

    RECEIVER_STATUS_PATTERN = %r(
      (?:
        v(?<version>\d+\.\d+\.\d+)
Severity: Minor
Found in lib/ogn_client/messages/receiver_status.rb - About 2 hrs to fix

    Method parse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse(raw, date: nil)
          @raw = raw
          @date = Date.parse(date) if date
          raw.match POSITION_PATTERN do |match|
            %i(callsign receiver time altitude).each do |attr|
    Severity: Minor
    Found in lib/ogn_client/message.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse(raw, date: nil)
          raw.match SENDER_BEACON_PATTERN do |match|
            super unless @raw
            %i(details id flight_level climb_rate turn_rate signal_power signal_quality errors frequency_offset gps_accuracy flarm_software_version flarm_hardware_version flarm_id proximity).each do |attr|
              send("#{attr}=", match[attr]) if match[attr]
    Severity: Minor
    Found in lib/ogn_client/messages/sender_beacon.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse(raw, date: nil)
          raw.match RECEIVER_STATUS_PATTERN do |match|
            super unless @raw
            %i(version platform cpu_load cpu_temperature ram_free ram_total ntp_offset ntp_correction voltage amperage rf_correction_manual rf_correction_automatic senders visible_senders signal_quality senders_signal_quality senders_messages good_senders_signal_quality good_and_bad_senders good_senders).each do |attr|
              send("#{attr}=", match[attr]) if match[attr]
    Severity: Minor
    Found in lib/ogn_client/messages/receiver_status.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passcode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def passcode(readonly: true)
          if readonly
            -1
          else
              @callsign.split('-').first.chars.reduce([0x73E2, true]) do |hash, char|
    Severity: Minor
    Found in lib/ogn_client/aprs.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language