Sign upLogin

switchkit/switchkit-cocoa

View on GitHub
Star

Showing 2 of 5 total issues

Function setValues has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public func setValues(fromDict registrationDictionary: [String: Any]) {
        func flattern(_ dict: [String: Any], path: String? = nil) -> [String: String] {
            var values: [String: String] = [:]
            for key in dict.keys {
                let keyPath = (path?.appending(".") ?? "").appending(key)
Severity: Minor
Found in Source/SwitchKit.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setValues has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public func setValues(fromDict registrationDictionary: [String: Any]) {
        func flattern(_ dict: [String: Any], path: String? = nil) -> [String: String] {
            var values: [String: String] = [:]
            for key in dict.keys {
                let keyPath = (path?.appending(".") ?? "").appending(key)
Severity: Minor
Found in Source/SwitchKit.swift - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language