Sign upLogin

symphonycms/symphony-2

View on GitHub
Star

Showing 844 of 844 total issues

Method __form has 791 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __form()
    {
        $formHasErrors = (is_array($this->_errors) && !empty($this->_errors));

        if ($formHasErrors) {
Severity: Major
Found in symphony/content/content.blueprintsdatasources.php - About 3 days to fix

    File content.publish.php has 1436 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * @package content
 */
    Severity: Major
    Found in symphony/content/content.publish.php - About 3 days to fix

      Function __form has a Cognitive Complexity of 172 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __form()
    {
        $formHasErrors = (is_array($this->_errors) && !empty($this->_errors));

        if ($formHasErrors) {
      Severity: Minor
      Found in symphony/content/content.blueprintsdatasources.php - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File content.blueprintsdatasources.php has 1269 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * @package content
 */
      Severity: Major
      Found in symphony/content/content.blueprintsdatasources.php - About 3 days to fix

        Function __actionNew has a Cognitive Complexity of 160 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __actionNew()
    {
        if (is_array($_POST['action']) && array_key_exists('save', $_POST['action'])) {
            $canProceed = true;
            $edit = ($this->_context['action'] === "edit");
        Severity: Minor
        Found in symphony/content/content.blueprintssections.php - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __viewIndex has a Cognitive Complexity of 142 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __viewIndex()
    {
        if (!$section_id = SectionManager::fetchIDFromHandle($this->_context['section_handle'])) {
            Administration::instance()->throwCustomError(
                __('The Section, %s, could not be found.', array('<code>' . $this->_context['section_handle'] . '</code>')),
        Severity: Minor
        Found in symphony/content/content.publish.php - About 2 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepareAssociationsDrawer has a Cognitive Complexity of 119 (exceeds 5 allowed). Consider refactoring.
        Open

            private function prepareAssociationsDrawer($section)
    {
        $entry_id = (!is_null($this->_context['entry_id'])) ? $this->_context['entry_id'] : null;
        $show_entries = Symphony::Configuration()->get('association_maximum_rows', 'symphony');
        Severity: Minor
        Found in symphony/content/content.publish.php - About 2 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File class.field.php has 882 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * @package toolkit
 */
/**
        Severity: Major
        Found in symphony/lib/toolkit/class.field.php - About 2 days to fix

          Function __formAction has a Cognitive Complexity of 102 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __formAction()
    {
        $fields = $_POST['fields'];
        $this->_errors = array();
        $providers = Symphony::ExtensionManager()->getProvidersOf(iProvider::DATASOURCE);
          Severity: Minor
          Found in symphony/content/content.blueprintsdatasources.php - About 2 days to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __viewIndex has 399 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __viewIndex()
    {
        if (!$section_id = SectionManager::fetchIDFromHandle($this->_context['section_handle'])) {
            Administration::instance()->throwCustomError(
                __('The Section, %s, could not be found.', array('<code>' . $this->_context['section_handle'] . '</code>')),
          Severity: Major
          Found in symphony/content/content.publish.php - About 1 day to fix

            Function __actionEdit has a Cognitive Complexity of 96 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __actionEdit()
    {
        if (!$author_id = $this->_context['id']) {
            redirect(SYMPHONY_URL . '/system/authors/');
        }
            Severity: Minor
            Found in symphony/content/content.systemauthors.php - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File class.general.php has 791 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
/**
 * @package toolkit
 */
/**
            Severity: Major
            Found in symphony/lib/toolkit/class.general.php - About 1 day to fix

              Function execute has a Cognitive Complexity of 91 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function execute(array &$param_pool = null)
    {
        $authorsQuery = (new AuthorManager)
            ->select()
            ->sort((string)$this->dsParamSORT, $this->dsParamORDER);
              Severity: Minor
              Found in symphony/lib/toolkit/data-sources/class.datasource.author.php - About 1 day to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function buildSingleWhereClauseFromArray has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
              Open

                  final public function buildSingleWhereClauseFromArray($k, $c)
    {
        $op = '=';
        if (is_object($c)) {
            if (!($c instanceof DatabaseSubQuery)) {
              Severity: Minor
              Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 1 day to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      case 'page':
            foreach ($data as $filename => $errors) {
                $error = new XMLElement('li', '<header class="frame-header">' . $filename . '<a class="debug" href="?debug=/workspace/pages/' .  $filename . $query_string .'" title="' . __('Show debug view') . '">' . __('Debug') . '</a></header>');
                $content = new XMLElement('div', null, array('class' => 'content'));
                $list = new XMLElement('ul');
              Severity: Major
              Found in symphony/template/usererror.xslt.php and 1 other location - About 1 day to fix
              symphony/template/usererror.xslt.php on lines 168..206

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 349.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      case 'utility':
            foreach ($data as $filename => $errors) {
                $error = new XMLElement('li', '<header class="frame-header">' . $filename . '<a class="debug" href="?debug=/workspace/utilities/' .  $filename . $query_string .'" title="' . __('Show debug view') . '">' . __('Debug') . '</a></header>');
                $content = new XMLElement('div', null, array('class' => 'content'));
                $list = new XMLElement('ul');
              Severity: Major
              Found in symphony/template/usererror.xslt.php and 1 other location - About 1 day to fix
              symphony/template/usererror.xslt.php on lines 129..167

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 349.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function __form has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __form($readonly = false)
    {
        $formHasErrors = (is_array($this->_errors) && !empty($this->_errors));

        if ($formHasErrors) {
              Severity: Minor
              Found in symphony/content/content.blueprintsevents.php - About 1 day to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File class.administrationpage.php has 684 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

/**
 * @package toolkit
 */
              Severity: Major
              Found in symphony/lib/toolkit/class.administrationpage.php - About 1 day to fix

                Function __actionIndex has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __actionIndex($resource_type)
    {
        $manager = ResourceManager::getManagerFromType($resource_type);
        $resource_name = str_replace('Manager', '', $manager);
        $delegate_path = strtolower($resource_name);
                Severity: Minor
                Found in symphony/lib/toolkit/class.resourcespage.php - About 1 day to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __actionEdit has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __actionEdit()
    {
        if ($this->_context['action'] !== 'new' && !$page_id = $this->_context['id']) {
            redirect(SYMPHONY_URL . '/blueprints/pages/');
        }
                Severity: Minor
                Found in symphony/content/content.blueprintspages.php - About 1 day to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language