Sign upLogin

symphonyoss/hubot-symphony

View on GitHub
Star

Showing 19 of 122 total issues

Function constructor has 301 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(args: ConstructorArgsType) {
    super();

    this.messages = [];
    this.host = args.host;
Severity: Major
Found in test/nock-server.js - About 1 day to fix

    File symphony.js has 407 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 *    Copyright 2017 Jon Freedman
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
 *    you may not use this file except in compliance with the License.
    Severity: Minor
    Found in src/symphony.js - About 5 hrs to fix

      File symphony-test.js has 397 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 *    Copyright 2017 Jon Freedman
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
 *    you may not use this file except in compliance with the License.
      Severity: Minor
      Found in test/symphony-test.js - About 5 hrs to fix

        File nock-server.js has 381 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
 *    Copyright 2017 Jon Freedman
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
 *    you may not use this file except in compliance with the License.
        Severity: Minor
        Found in test/nock-server.js - About 5 hrs to fix

          Symphony has 26 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Symphony {
  host: string;
  keyManagerHost: string;
  sessionAuthHost: string;
  agentHost: string;
          Severity: Minor
          Found in src/symphony.js - About 3 hrs to fix

            File adapter.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /**
 *    Copyright 2017 Jon Freedman
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
 *    you may not use this file except in compliance with the License.
            Severity: Minor
            Found in src/adapter.js - About 2 hrs to fix

              Function constructor has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                constructor(robot: Robot, options: AdapterOptionsType) {
    super(robot);
    this.robot = robot;

    if (process.env.HUBOT_SYMPHONY_HOST === undefined || process.env.HUBOT_SYMPHONY_HOST === null) {
              Severity: Major
              Found in src/adapter.js - About 2 hrs to fix

                Line 671 exceeds the maximum line length of 120.
                Open

                  _httpRequest<T>(method: string, host: string, path: string, headers: HttpHeaderType, body: ?mixed, formData: ?mixed): Promise<T> {
                Severity: Minor
                Found in src/symphony.js by eslint

                enforce a maximum line length (max-len)

                Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

                var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

                Rule Details

                This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

                Options

                This rule has a number or object option:

                • "code" (default 80) enforces a maximum line length
                • "tabWidth" (default 4) specifies the character width for tab characters
                • "comments" enforces a maximum line length for comments; defaults to value of code
                • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
                • "ignoreComments": true ignores all trailing comments and comments on their own line
                • "ignoreTrailingComments": true ignores only trailing comments
                • "ignoreUrls": true ignores lines that contain a URL
                • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
                • "ignoreTemplateLiterals": true ignores lines that contain a template literal
                • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

                code

                Examples of incorrect code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

                Examples of correct code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = {
  "bar": "This is a bar.",
  "baz": { "qux": "This is a qux" },
  "easier": "to read"
};

                tabWidth

                Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

                Examples of correct code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = {
\t  \t  \t  \t  "bar": "This is a bar.",
\t  \t  \t  \t  "baz": { "qux": "This is a qux" }
\t  \t  };

                comments

                Examples of incorrect code for this rule with the { "comments": 65 } option:

                /*eslint max-len: ["error", { "comments": 65 }]*/

/**
 * This is a comment that violates the maximum line length we have specified
**/

                ignoreComments

                Examples of correct code for this rule with the { "ignoreComments": true } option:

                /*eslint max-len: ["error", { "ignoreComments": true }]*/

/**
 * This is a really really really really really really really really really long comment
**/

                ignoreTrailingComments

                Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

                /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/

var foo = 'bar'; // This is a really really really really really really really long comment

                ignoreUrls

                Examples of correct code for this rule with the { "ignoreUrls": true } option:

                /*eslint max-len: ["error", { "ignoreUrls": true }]*/

var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

                ignoreStrings

                Examples of correct code for this rule with the { "ignoreStrings": true } option:

                /*eslint max-len: ["error", { "ignoreStrings": true }]*/

var longString = 'this is a really really really really really long string!';

                ignoreTemplateLiterals

                Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/

var longTemplateLiteral = `this is a really really really really really long template literal!`;

                ignoreRegExpLiterals

                Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/

var longRegExpLiteral = /this is a really really really really really long regular expression!/;

                ignorePattern

                Examples of correct code for this rule with the { "ignorePattern": true } option:

                /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/

var dep = require('really/really/really/really/really/really/really/really/long/module');

                Related Rules

                • [complexity](complexity.md)
                • [max-depth](max-depth.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Line 703 exceeds the maximum line length of 120.
                Open

                          logger.debug(`received ${res.statusCode} response from https://${host}${path}: ${JSON.stringify(data) || 'undefined'}`);
                Severity: Minor
                Found in src/symphony.js by eslint

                enforce a maximum line length (max-len)

                Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

                var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

                Rule Details

                This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

                Options

                This rule has a number or object option:

                • "code" (default 80) enforces a maximum line length
                • "tabWidth" (default 4) specifies the character width for tab characters
                • "comments" enforces a maximum line length for comments; defaults to value of code
                • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
                • "ignoreComments": true ignores all trailing comments and comments on their own line
                • "ignoreTrailingComments": true ignores only trailing comments
                • "ignoreUrls": true ignores lines that contain a URL
                • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
                • "ignoreTemplateLiterals": true ignores lines that contain a template literal
                • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

                code

                Examples of incorrect code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

                Examples of correct code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = {
  "bar": "This is a bar.",
  "baz": { "qux": "This is a qux" },
  "easier": "to read"
};

                tabWidth

                Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

                Examples of correct code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = {
\t  \t  \t  \t  "bar": "This is a bar.",
\t  \t  \t  \t  "baz": { "qux": "This is a qux" }
\t  \t  };

                comments

                Examples of incorrect code for this rule with the { "comments": 65 } option:

                /*eslint max-len: ["error", { "comments": 65 }]*/

/**
 * This is a comment that violates the maximum line length we have specified
**/

                ignoreComments

                Examples of correct code for this rule with the { "ignoreComments": true } option:

                /*eslint max-len: ["error", { "ignoreComments": true }]*/

/**
 * This is a really really really really really really really really really long comment
**/

                ignoreTrailingComments

                Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

                /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/

var foo = 'bar'; // This is a really really really really really really really long comment

                ignoreUrls

                Examples of correct code for this rule with the { "ignoreUrls": true } option:

                /*eslint max-len: ["error", { "ignoreUrls": true }]*/

var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

                ignoreStrings

                Examples of correct code for this rule with the { "ignoreStrings": true } option:

                /*eslint max-len: ["error", { "ignoreStrings": true }]*/

var longString = 'this is a really really really really really long string!';

                ignoreTemplateLiterals

                Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/

var longTemplateLiteral = `this is a really really really really really long template literal!`;

                ignoreRegExpLiterals

                Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/

var longRegExpLiteral = /this is a really really really really really long regular expression!/;

                ignorePattern

                Examples of correct code for this rule with the { "ignorePattern": true } option:

                /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/

var dep = require('really/really/really/really/really/really/really/really/long/module');

                Related Rules

                • [complexity](complexity.md)
                • [max-depth](max-depth.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Line 699 exceeds the maximum line length of 120.
                Open

                          const err = `received ${res.statusCode} response from https://${host}${path}: ${JSON.stringify(data) || 'undefined'}`;
                Severity: Minor
                Found in src/symphony.js by eslint

                enforce a maximum line length (max-len)

                Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

                var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

                Rule Details

                This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

                Options

                This rule has a number or object option:

                • "code" (default 80) enforces a maximum line length
                • "tabWidth" (default 4) specifies the character width for tab characters
                • "comments" enforces a maximum line length for comments; defaults to value of code
                • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
                • "ignoreComments": true ignores all trailing comments and comments on their own line
                • "ignoreTrailingComments": true ignores only trailing comments
                • "ignoreUrls": true ignores lines that contain a URL
                • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
                • "ignoreTemplateLiterals": true ignores lines that contain a template literal
                • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

                code

                Examples of incorrect code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

                Examples of correct code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = {
  "bar": "This is a bar.",
  "baz": { "qux": "This is a qux" },
  "easier": "to read"
};

                tabWidth

                Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

                Examples of correct code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = {
\t  \t  \t  \t  "bar": "This is a bar.",
\t  \t  \t  \t  "baz": { "qux": "This is a qux" }
\t  \t  };

                comments

                Examples of incorrect code for this rule with the { "comments": 65 } option:

                /*eslint max-len: ["error", { "comments": 65 }]*/

/**
 * This is a comment that violates the maximum line length we have specified
**/

                ignoreComments

                Examples of correct code for this rule with the { "ignoreComments": true } option:

                /*eslint max-len: ["error", { "ignoreComments": true }]*/

/**
 * This is a really really really really really really really really really long comment
**/

                ignoreTrailingComments

                Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

                /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/

var foo = 'bar'; // This is a really really really really really really really long comment

                ignoreUrls

                Examples of correct code for this rule with the { "ignoreUrls": true } option:

                /*eslint max-len: ["error", { "ignoreUrls": true }]*/

var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

                ignoreStrings

                Examples of correct code for this rule with the { "ignoreStrings": true } option:

                /*eslint max-len: ["error", { "ignoreStrings": true }]*/

var longString = 'this is a really really really really really long string!';

                ignoreTemplateLiterals

                Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/

var longTemplateLiteral = `this is a really really really really really long template literal!`;

                ignoreRegExpLiterals

                Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/

var longRegExpLiteral = /this is a really really really really really long regular expression!/;

                ignorePattern

                Examples of correct code for this rule with the { "ignorePattern": true } option:

                /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/

var dep = require('really/really/really/really/really/really/really/really/long/module');

                Related Rules

                • [complexity](complexity.md)
                • [max-depth](max-depth.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Line 26 exceeds the maximum line length of 120.
                Open

                import type {EchoType, SymphonyMessageV2Type, SymphonyMessageV4Type, RoomInfoType, RoomInfoAlternateType} from '../src/symphony';
                Severity: Minor
                Found in test/nock-server.js by eslint

                enforce a maximum line length (max-len)

                Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

                var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

                Rule Details

                This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

                Options

                This rule has a number or object option:

                • "code" (default 80) enforces a maximum line length
                • "tabWidth" (default 4) specifies the character width for tab characters
                • "comments" enforces a maximum line length for comments; defaults to value of code
                • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
                • "ignoreComments": true ignores all trailing comments and comments on their own line
                • "ignoreTrailingComments": true ignores only trailing comments
                • "ignoreUrls": true ignores lines that contain a URL
                • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
                • "ignoreTemplateLiterals": true ignores lines that contain a template literal
                • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

                code

                Examples of incorrect code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

                Examples of correct code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = {
  "bar": "This is a bar.",
  "baz": { "qux": "This is a qux" },
  "easier": "to read"
};

                tabWidth

                Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

                Examples of correct code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = {
\t  \t  \t  \t  "bar": "This is a bar.",
\t  \t  \t  \t  "baz": { "qux": "This is a qux" }
\t  \t  };

                comments

                Examples of incorrect code for this rule with the { "comments": 65 } option:

                /*eslint max-len: ["error", { "comments": 65 }]*/

/**
 * This is a comment that violates the maximum line length we have specified
**/

                ignoreComments

                Examples of correct code for this rule with the { "ignoreComments": true } option:

                /*eslint max-len: ["error", { "ignoreComments": true }]*/

/**
 * This is a really really really really really really really really really long comment
**/

                ignoreTrailingComments

                Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

                /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/

var foo = 'bar'; // This is a really really really really really really really long comment

                ignoreUrls

                Examples of correct code for this rule with the { "ignoreUrls": true } option:

                /*eslint max-len: ["error", { "ignoreUrls": true }]*/

var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

                ignoreStrings

                Examples of correct code for this rule with the { "ignoreStrings": true } option:

                /*eslint max-len: ["error", { "ignoreStrings": true }]*/

var longString = 'this is a really really really really really long string!';

                ignoreTemplateLiterals

                Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/

var longTemplateLiteral = `this is a really really really really really long template literal!`;

                ignoreRegExpLiterals

                Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/

var longRegExpLiteral = /this is a really really really really really long regular expression!/;

                ignorePattern

                Examples of correct code for this rule with the { "ignorePattern": true } option:

                /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/

var dep = require('really/really/really/really/really/really/really/really/long/module');

                Related Rules

                • [complexity](complexity.md)
                • [max-depth](max-depth.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Line 692 exceeds the maximum line length of 120.
                Open

                      logger.debug(`sending ${options.method} to https://${host}${path} [body: ${JSON.stringify(options.body) || 'undefined'}] [formData: ${JSON.stringify(options.formData) || 'undefined'}]`);
                Severity: Minor
                Found in src/symphony.js by eslint

                enforce a maximum line length (max-len)

                Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

                var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

                Rule Details

                This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

                Options

                This rule has a number or object option:

                • "code" (default 80) enforces a maximum line length
                • "tabWidth" (default 4) specifies the character width for tab characters
                • "comments" enforces a maximum line length for comments; defaults to value of code
                • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
                • "ignoreComments": true ignores all trailing comments and comments on their own line
                • "ignoreTrailingComments": true ignores only trailing comments
                • "ignoreUrls": true ignores lines that contain a URL
                • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
                • "ignoreTemplateLiterals": true ignores lines that contain a template literal
                • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

                code

                Examples of incorrect code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

                Examples of correct code for this rule with the default { "code": 80 } option:

                /*eslint max-len: ["error", 80]*/

var foo = {
  "bar": "This is a bar.",
  "baz": { "qux": "This is a qux" },
  "easier": "to read"
};

                tabWidth

                Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

                Examples of correct code for this rule with the default { "tabWidth": 4 } option:

                /*eslint max-len: ["error", 80, 4]*/

\t  \t  var foo = {
\t  \t  \t  \t  "bar": "This is a bar.",
\t  \t  \t  \t  "baz": { "qux": "This is a qux" }
\t  \t  };

                comments

                Examples of incorrect code for this rule with the { "comments": 65 } option:

                /*eslint max-len: ["error", { "comments": 65 }]*/

/**
 * This is a comment that violates the maximum line length we have specified
**/

                ignoreComments

                Examples of correct code for this rule with the { "ignoreComments": true } option:

                /*eslint max-len: ["error", { "ignoreComments": true }]*/

/**
 * This is a really really really really really really really really really long comment
**/

                ignoreTrailingComments

                Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

                /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/

var foo = 'bar'; // This is a really really really really really really really long comment

                ignoreUrls

                Examples of correct code for this rule with the { "ignoreUrls": true } option:

                /*eslint max-len: ["error", { "ignoreUrls": true }]*/

var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

                ignoreStrings

                Examples of correct code for this rule with the { "ignoreStrings": true } option:

                /*eslint max-len: ["error", { "ignoreStrings": true }]*/

var longString = 'this is a really really really really really long string!';

                ignoreTemplateLiterals

                Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/

var longTemplateLiteral = `this is a really really really really really long template literal!`;

                ignoreRegExpLiterals

                Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

                /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/

var longRegExpLiteral = /this is a really really really really really long regular expression!/;

                ignorePattern

                Examples of correct code for this rule with the { "ignorePattern": true } option:

                /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/

var dep = require('really/really/really/really/really/really/really/really/long/module');

                Related Rules

                • [complexity](complexity.md)
                • [max-depth](max-depth.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Function run has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  run() {
    this.robot.logger.info('Initialising...');

    const getEnv = function(key: string, defaultVal: ?string): string {
      const value = process.env[key];
                Severity: Minor
                Found in src/adapter.js - About 1 hr to fix

                  Function constructor has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    constructor() {
    super();

    // echo any errors
    this.on('error', function(err: Error) {
                  Severity: Minor
                  Found in test/fakes.js - About 1 hr to fix

                    Function _httpRequest has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      _httpRequest<T>(method: string, host: string, path: string, headers: HttpHeaderType, body: ?mixed, formData: ?mixed): Promise<T> {
    let self = this;
    return new Promise((resolve, reject) => {
      let options = {
        baseUrl: `https://${host}`,
                    Severity: Minor
                    Found in src/symphony.js - About 1 hr to fix

                      Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        constructor(args: ConstructorArgsType) {
    this.host = args.host;
    this.keyManagerHost = args.keyManagerHost || args.host;
    this.sessionAuthHost = args.sessionAuthHost || args.host;
    this.agentHost = args.agentHost || args.host;
                      Severity: Minor
                      Found in src/symphony.js - About 1 hr to fix

                        Function send has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                          send(envelope: SimpleMessageEnvelopeType, ...messages: Array<MessageTypeOrString>) {
    this.robot.logger.debug(`Sending ${messages.length} messages to ${envelope.room}`);
    for (const message of messages) {
      if (typeof message === 'string') {
        let messageML = message;
                        Severity: Minor
                        Found in src/adapter.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                          constructor(robot: Robot, options: AdapterOptionsType) {
    super(robot);
    this.robot = robot;

    if (process.env.HUBOT_SYMPHONY_HOST === undefined || process.env.HUBOT_SYMPHONY_HOST === null) {
                        Severity: Minor
                        Found in src/adapter.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                          constructor() {
    super();

    // echo any errors
    this.on('error', function(err: Error) {
                        Severity: Minor
                        Found in test/fakes.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language