t3labcom/capistrano-typo3

View on GitHub
lib/capistrano/typo3/dt3_mysql.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for db_image_list is too high. [36.89/15]
Open

  def self.db_image_list
    images_arr = []
    idx = 0

    Dir.glob("#{TYPO3_DB_DUMP_DIR}/*.sql").sort.each {|sql|
Severity: Minor
Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [24/10]
Open

  def self.db_image_list
    images_arr = []
    idx = 0

    Dir.glob("#{TYPO3_DB_DUMP_DIR}/*.sql").sort.each {|sql|
Severity: Minor
Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [17/10]
Open

  def self.dump_db_version(table_exclude_list=nil)

    filename =''
    numbers = []

Severity: Minor
Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for dump_db_version is too high. [19.42/15]
Open

  def self.dump_db_version(table_exclude_list=nil)

    filename =''
    numbers = []

Severity: Minor
Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method create_mysql_base_command_with has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.create_mysql_base_command_with(user,host,password,db,exec='mysql')
Severity: Minor
Found in lib/capistrano/typo3/dt3_mysql.rb - About 35 mins to fix

    Method db_image_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.db_image_list
        images_arr = []
        idx = 0
    
        Dir.glob("#{TYPO3_DB_DUMP_DIR}/*.sql").sort.each {|sql|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use delete instead of gsub.
    Open

        branch = `git rev-parse --abbrev-ref HEAD`.gsub("\n",'')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop identifies places where gsub can be replaced by tr or delete.

    Example:

    # bad
    'abc'.gsub('b', 'd')
    'abc'.gsub('a', '')
    'abc'.gsub(/a/, 'd')
    'abc'.gsub!('a', 'd')
    
    # good
    'abc'.gsub(/.*/, 'a')
    'abc'.gsub(/a+/, 'd')
    'abc'.tr('b', 'd')
    'a b c'.delete(' ')

    Use empty lines between method definitions.
    Open

      def self.create_mysql_base_command(exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks whether method definitions are separated by one empty line.

    NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

    AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

    Example:

    # bad
    def a
    end
    def b
    end

    Example:

    # good
    def a
    end
    
    def b
    end

    Extra empty line detected at method body beginning.
    Open

    
        if(not excludelist.nil?)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cops checks if empty lines exist around the bodies of methods.

    Example:

    # good
    
    def foo
      # ...
    end
    
    # bad
    
    def bar
    
      # ...
    
    end

    Space after keyword elsif is missing.
    Open

            elsif(sql.split('-').count == 2)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks the spacing around the keywords.

    Example:

    # bad
    something 'test'do|x|
    end
    
    while(something)
    end
    
    something = 123if test
    
    # good
    something 'test' do |x|
    end
    
    while (something)
    end
    
    something = 123 if test

    Space between { and | missing.
    Open

        Dir.foreach(TYPO3_DB_DUMP_DIR) {|sql|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

    Example: EnforcedStyle: space (default)

    # The `space` style enforces that block braces have
    # surrounding space.
    
    # bad
    some_array.each {puts e}
    
    # good
    some_array.each { puts e }

    Example: EnforcedStyle: no_space

    # The `no_space` style enforces that block braces don't
    # have surrounding space.
    
    # bad
    some_array.each { puts e }
    
    # good
    some_array.each {puts e}

    Example: EnforcedStyleForEmptyBraces: no_space (default)

    # The `no_space` EnforcedStyleForEmptyBraces style enforces that
    # block braces don't have a space in between when empty.
    
    # bad
    some_array.each {   }
    some_array.each {  }
    some_array.each { }
    
    # good
    some_array.each {}

    Example: EnforcedStyleForEmptyBraces: space

    # The `space` EnforcedStyleForEmptyBraces style enforces that
    # block braces have at least a spece in between when empty.
    
    # bad
    some_array.each {}
    
    # good
    some_array.each { }
    some_array.each {  }
    some_array.each {   }

    Example: SpaceBeforeBlockParameters: true (default)

    # The SpaceBeforeBlockParameters style set to `true` enforces that
    # there is a space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each {|n| n * 2 }
    
    # good
    [1, 2, 3].each { |n| n * 2 }

    Example: SpaceBeforeBlockParameters: true

    # The SpaceBeforeBlockParameters style set to `false` enforces that
    # there is no space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each { |n| n * 2 }
    
    # good
    [1, 2, 3].each {|n| n * 2 }

    Space missing after comma.
    Open

        filename = File.join(TYPO3_DB_DUMP_DIR,"#{fetch(:dbname)}-#{branch}.#{version.to_s}.sql")
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Space missing after comma.
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Redundant return detected.
    Open

        return cmd
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Redundant self detected.
    Open

        tablelist = `#{self.create_mysql_base_command} -e "show tables" | grep -v Tables_in | grep -v "+"`
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Line is too long. [102/80]
    Open

        tablelist = `#{self.create_mysql_base_command} -e "show tables" | grep -v Tables_in | grep -v "+"`
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Redundant return detected.
    Open

          return '/usr/bin'
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Space missing after comma.
    Open

      def self.create_mysql_base_command_with(user,host,password,db,exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Use the return of the conditional for variable assignment and comparison.
    Open

        if(not excludelist.nil?)
          excludestring = self.create_exclude_string(excludelist)
        else
          excludestring = ''
        end
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Redundant return detected.
    Open

          return fetch(:rake_mysql_exec_dir)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Space missing after comma.
    Open

      def self.mysqldump_to(outputfile,excludelist=nil,no_schema=nil)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Surrounding space missing for operator >.
    Open

          if(s.length>0)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that operators have space around them, except for ** which should not have surrounding space.

    Example:

    # bad
    total = 3*4
    "apple"+"juice"
    my_number = 38/4
    a ** b
    
    # good
    total = 3 * 4
    "apple" + "juice"
    my_number = 38 / 4
    a**b

    Use the return of the conditional for variable assignment and comparison.
    Open

        if(numbers.count > 0)
          version = (numbers.max + 1)
        else
          version = 1
        end
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Missing top-level class documentation comment.
    Open

    class DT3MySQL
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
    Open

          if(tmpname.count == 3)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

    Example:

    # bad
    if condition
      do_stuff(bar)
    end
    
    unless qux.empty?
      Foo.do_something
    end
    
    # good
    do_stuff(bar) if condition
    Foo.do_something unless qux.empty?

    Redundant return detected.
    Open

        return self.mysql_execute('show tables')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Space after keyword if is missing.
    Open

          if(tmpname.count == 3)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks the spacing around the keywords.

    Example:

    # bad
    something 'test'do|x|
    end
    
    while(something)
    end
    
    something = 123if test
    
    # good
    something 'test' do |x|
    end
    
    while (something)
    end
    
    something = 123 if test

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

        if fetch(:rake_mysql_exec_dir)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
    def test
      if something
        work
      end
    end
    
    # good
    def test
      return unless something
      work
    end
    
    # also good
    def test
      work if something
    end
    
    # bad
    if something
      raise 'exception'
    else
      ok
    end
    
    # good
    raise 'exception' if something
    ok

    Space missing after comma.
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Space between { and | missing.
    Open

        Dir.glob("#{TYPO3_DB_DUMP_DIR}/*.sql").sort.each {|sql|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

    Example: EnforcedStyle: space (default)

    # The `space` style enforces that block braces have
    # surrounding space.
    
    # bad
    some_array.each {puts e}
    
    # good
    some_array.each { puts e }

    Example: EnforcedStyle: no_space

    # The `no_space` style enforces that block braces don't
    # have surrounding space.
    
    # bad
    some_array.each { puts e }
    
    # good
    some_array.each {puts e}

    Example: EnforcedStyleForEmptyBraces: no_space (default)

    # The `no_space` EnforcedStyleForEmptyBraces style enforces that
    # block braces don't have a space in between when empty.
    
    # bad
    some_array.each {   }
    some_array.each {  }
    some_array.each { }
    
    # good
    some_array.each {}

    Example: EnforcedStyleForEmptyBraces: space

    # The `space` EnforcedStyleForEmptyBraces style enforces that
    # block braces have at least a spece in between when empty.
    
    # bad
    some_array.each {}
    
    # good
    some_array.each { }
    some_array.each {  }
    some_array.each {   }

    Example: SpaceBeforeBlockParameters: true (default)

    # The SpaceBeforeBlockParameters style set to `true` enforces that
    # there is a space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each {|n| n * 2 }
    
    # good
    [1, 2, 3].each { |n| n * 2 }

    Example: SpaceBeforeBlockParameters: true

    # The SpaceBeforeBlockParameters style set to `false` enforces that
    # there is no space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each { |n| n * 2 }
    
    # good
    [1, 2, 3].each {|n| n * 2 }

    Space between { and | missing.
    Open

        excludelist.each {|extab|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

    Example: EnforcedStyle: space (default)

    # The `space` style enforces that block braces have
    # surrounding space.
    
    # bad
    some_array.each {puts e}
    
    # good
    some_array.each { puts e }

    Example: EnforcedStyle: no_space

    # The `no_space` style enforces that block braces don't
    # have surrounding space.
    
    # bad
    some_array.each { puts e }
    
    # good
    some_array.each {puts e}

    Example: EnforcedStyleForEmptyBraces: no_space (default)

    # The `no_space` EnforcedStyleForEmptyBraces style enforces that
    # block braces don't have a space in between when empty.
    
    # bad
    some_array.each {   }
    some_array.each {  }
    some_array.each { }
    
    # good
    some_array.each {}

    Example: EnforcedStyleForEmptyBraces: space

    # The `space` EnforcedStyleForEmptyBraces style enforces that
    # block braces have at least a spece in between when empty.
    
    # bad
    some_array.each {}
    
    # good
    some_array.each { }
    some_array.each {  }
    some_array.each {   }

    Example: SpaceBeforeBlockParameters: true (default)

    # The SpaceBeforeBlockParameters style set to `true` enforces that
    # there is a space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each {|n| n * 2 }
    
    # good
    [1, 2, 3].each { |n| n * 2 }

    Example: SpaceBeforeBlockParameters: true

    # The SpaceBeforeBlockParameters style set to `false` enforces that
    # there is no space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each { |n| n * 2 }
    
    # good
    [1, 2, 3].each {|n| n * 2 }

    Redundant self detected.
    Open

        self.mysql_execute(dropsql)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Redundant self detected.
    Open

        self.mysql_execute("TRUNCATE TABLE #{table};")
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Space missing after comma.
    Open

      def self.create_mysql_base_command_with(user,host,password,db,exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Redundant return detected.
    Open

        return images_arr
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Extra blank line detected.
    Open

    
      def self.create_mysql_base_command(exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cops checks for two or more consecutive blank lines.

    Example:

    # bad - It has two empty lines.
    some_method
    # one empty line
    # two empty lines
    some_method
    
    # good
    some_method
    # one empty line
    some_method

    Space missing after comma.
    Open

        branch = `git rev-parse --abbrev-ref HEAD`.gsub("\n",'')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Surrounding space missing in default value assignment.
    Open

      def self.mysqldump_to(outputfile,excludelist=nil,no_schema=nil)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

    Example:

    # bad
    def some_method(arg1=:default, arg2=nil, arg3=[])
      # do something...
    end
    
    # good
    def some_method(arg1 = :default, arg2 = nil, arg3 = [])
      # do something...
    end

    Surrounding space missing for operator =.
    Open

        filename =''
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that operators have space around them, except for ** which should not have surrounding space.

    Example:

    # bad
    total = 3*4
    "apple"+"juice"
    my_number = 38/4
    a ** b
    
    # good
    total = 3 * 4
    "apple" + "juice"
    my_number = 38 / 4
    a**b

    Unused method argument - no_schema. If it's necessary, use _ or _no_schema as an argument name to indicate that it won't be used.
    Open

      def self.mysqldump_to(outputfile,excludelist=nil,no_schema=nil)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad
    
    def some_method(used, unused, _unused_but_allowed)
      puts used
    end

    Example:

    # good
    
    def some_method(used, _unused, _unused_but_allowed)
      puts used
    end

    Line is too long. [93/80]
    Open

        filename = File.join(TYPO3_DB_DUMP_DIR,"#{fetch(:dbname)}-#{branch}.#{version.to_s}.sql")
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Use hash literal {} instead of Hash.new.
    Open

          image = Hash.new
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for the use of a method, the result of which would be a literal, like an empty array, hash or string.

    Example:

    # bad
    a = Array.new
    h = Hash.new
    s = String.new
    
    # good
    a = []
    h = {}
    s = ''

    Redundant self detected.
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Redundant self detected.
    Open

        "#{self.create_mysql_base_command} -e \"#{sql}\""
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Use self-assignment shorthand +=.
    Open

            idx = idx+1
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop enforces the use the shorthand for self-assignment.

    Example:

    # bad
    x = x + 1
    
    # good
    x += 1

    Space after keyword if is missing.
    Open

        if(numbers.count > 0)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks the spacing around the keywords.

    Example:

    # bad
    something 'test'do|x|
    end
    
    while(something)
    end
    
    something = 123if test
    
    # good
    something 'test' do |x|
    end
    
    while (something)
    end
    
    something = 123 if test

    Redundant use of Object#to_s in interpolation.
    Open

        filename = File.join(TYPO3_DB_DUMP_DIR,"#{fetch(:dbname)}-#{branch}.#{version.to_s}.sql")
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for string conversion in string interpolation, which is redundant.

    Example:

    # bad
    
    "result is #{something.to_s}"

    Example:

    # good
    
    "result is #{something}"

    Avoid using {...} for multi-line blocks.
    Open

        tablelist.split("\n").each {|table|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Check for uses of braces or do/end around single line or multi-line blocks.

    Example: EnforcedStyle: linecountbased (default)

    # bad - single line block
    items.each do |item| item / 5 end
    
    # good - single line block
    items.each { |item| item / 5 }
    
    # bad - multi-line block
    things.map { |thing|
      something = thing.some_method
      process(something)
    }
    
    # good - multi-line block
    things.map do |thing|
      something = thing.some_method
      process(something)
    end

    Example: EnforcedStyle: semantic

    # Prefer `do...end` over `{...}` for procedural blocks.
    
    # return value is used/assigned
    # bad
    foo = map do |x|
      x
    end
    puts (map do |x|
      x
    end)
    
    # return value is not used out of scope
    # good
    map do |x|
      x
    end
    
    # Prefer `{...}` over `do...end` for functional blocks.
    
    # return value is not used out of scope
    # bad
    each { |x|
      x
    }
    
    # return value is used/assigned
    # good
    foo = map { |x|
      x
    }
    map { |x|
      x
    }.inspect

    Example: EnforcedStyle: bracesforchaining

    # bad
    words.each do |word|
      word.flip.flop
    end.join("-")
    
    # good
    words.each { |word|
      word.flip.flop
    }.join("-")

    Redundant self detected.
    Open

          excludestring = self.create_exclude_string(excludelist)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Space missing after comma.
    Open

      def self.create_mysql_base_command_with(user,host,password,db,exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Space missing after comma.
    Open

              image['name'] = File.basename(sql,'.*')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Space missing after comma.
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Surrounding space missing in default value assignment.
    Open

      def self.mysqldump_to(outputfile,excludelist=nil,no_schema=nil)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

    Example:

    # bad
    def some_method(arg1=:default, arg2=nil, arg3=[])
      # do something...
    end
    
    # good
    def some_method(arg1 = :default, arg2 = nil, arg3 = [])
      # do something...
    end

    Space between { and | missing.
    Open

        tablelist.split("\n").each {|table|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

    Example: EnforcedStyle: space (default)

    # The `space` style enforces that block braces have
    # surrounding space.
    
    # bad
    some_array.each {puts e}
    
    # good
    some_array.each { puts e }

    Example: EnforcedStyle: no_space

    # The `no_space` style enforces that block braces don't
    # have surrounding space.
    
    # bad
    some_array.each { puts e }
    
    # good
    some_array.each {puts e}

    Example: EnforcedStyleForEmptyBraces: no_space (default)

    # The `no_space` EnforcedStyleForEmptyBraces style enforces that
    # block braces don't have a space in between when empty.
    
    # bad
    some_array.each {   }
    some_array.each {  }
    some_array.each { }
    
    # good
    some_array.each {}

    Example: EnforcedStyleForEmptyBraces: space

    # The `space` EnforcedStyleForEmptyBraces style enforces that
    # block braces have at least a spece in between when empty.
    
    # bad
    some_array.each {}
    
    # good
    some_array.each { }
    some_array.each {  }
    some_array.each {   }

    Example: SpaceBeforeBlockParameters: true (default)

    # The SpaceBeforeBlockParameters style set to `true` enforces that
    # there is a space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each {|n| n * 2 }
    
    # good
    [1, 2, 3].each { |n| n * 2 }

    Example: SpaceBeforeBlockParameters: true

    # The SpaceBeforeBlockParameters style set to `false` enforces that
    # there is no space between `{` and `|`. Overrides `EnforcedStyle`
    # if there is a conflict.
    
    # bad
    [1, 2, 3].each { |n| n * 2 }
    
    # good
    [1, 2, 3].each {|n| n * 2 }

    Avoid using {...} for multi-line blocks.
    Open

        Dir.glob("#{TYPO3_DB_DUMP_DIR}/*.sql").sort.each {|sql|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Check for uses of braces or do/end around single line or multi-line blocks.

    Example: EnforcedStyle: linecountbased (default)

    # bad - single line block
    items.each do |item| item / 5 end
    
    # good - single line block
    items.each { |item| item / 5 }
    
    # bad - multi-line block
    things.map { |thing|
      something = thing.some_method
      process(something)
    }
    
    # good - multi-line block
    things.map do |thing|
      something = thing.some_method
      process(something)
    end

    Example: EnforcedStyle: semantic

    # Prefer `do...end` over `{...}` for procedural blocks.
    
    # return value is used/assigned
    # bad
    foo = map do |x|
      x
    end
    puts (map do |x|
      x
    end)
    
    # return value is not used out of scope
    # good
    map do |x|
      x
    end
    
    # Prefer `{...}` over `do...end` for functional blocks.
    
    # return value is not used out of scope
    # bad
    each { |x|
      x
    }
    
    # return value is used/assigned
    # good
    foo = map { |x|
      x
    }
    map { |x|
      x
    }.inspect

    Example: EnforcedStyle: bracesforchaining

    # bad
    words.each do |word|
      word.flip.flop
    end.join("-")
    
    # good
    words.each { |word|
      word.flip.flop
    }.join("-")

    Avoid using {...} for multi-line blocks.
    Open

        excludelist.each {|extab|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Check for uses of braces or do/end around single line or multi-line blocks.

    Example: EnforcedStyle: linecountbased (default)

    # bad - single line block
    items.each do |item| item / 5 end
    
    # good - single line block
    items.each { |item| item / 5 }
    
    # bad - multi-line block
    things.map { |thing|
      something = thing.some_method
      process(something)
    }
    
    # good - multi-line block
    things.map do |thing|
      something = thing.some_method
      process(something)
    end

    Example: EnforcedStyle: semantic

    # Prefer `do...end` over `{...}` for procedural blocks.
    
    # return value is used/assigned
    # bad
    foo = map do |x|
      x
    end
    puts (map do |x|
      x
    end)
    
    # return value is not used out of scope
    # good
    map do |x|
      x
    end
    
    # Prefer `{...}` over `do...end` for functional blocks.
    
    # return value is not used out of scope
    # bad
    each { |x|
      x
    }
    
    # return value is used/assigned
    # good
    foo = map { |x|
      x
    }
    map { |x|
      x
    }.inspect

    Example: EnforcedStyle: bracesforchaining

    # bad
    words.each do |word|
      word.flip.flop
    end.join("-")
    
    # good
    words.each { |word|
      word.flip.flop
    }.join("-")

    Favor format over String#%.
    Open

            image['filesize (Mb)'] = '%.2f' % (File.size(sql).to_f / 2**20)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop enforces the use of a single string formatting utility. Valid options include Kernel#format, Kernel#sprintf and String#%.

    The detection of String#% cannot be implemented in a reliable manner for all cases, so only two scenarios are considered - if the first argument is a string literal and if the second argument is an array literal.

    Example: EnforcedStyle: format(default)

    # bad
    puts sprintf('%10s', 'hoge')
    puts '%10s' % 'hoge'
    
    # good
    puts format('%10s', 'hoge')

    Example: EnforcedStyle: sprintf

    # bad
    puts format('%10s', 'hoge')
    puts '%10s' % 'hoge'
    
    # good
    puts sprintf('%10s', 'hoge')

    Example: EnforcedStyle: percent

    # bad
    puts format('%10s', 'hoge')
    puts sprintf('%10s', 'hoge')
    
    # good
    puts '%10s' % 'hoge'

    Prefer annotated tokens (like %<foo>s</foo>) over unannotated tokens (like %s).
    Open

            image['time'] = File.mtime(sql).strftime("%Y-%m-%d %H:%M")
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Use a consistent style for named format string tokens.

    Note: unannotated style cop only works for strings which are passed as arguments to those methods: sprintf, format, %. The reason is that unannotated format is very similar to encoded URLs or Date/Time formatting strings.

    Example: EnforcedStyle: annotated (default)

    # bad
    format('%{greeting}', greeting: 'Hello')
    format('%s', 'Hello')
    
    # good
    format('%<greeting>s', greeting: 'Hello')</greeting>

    Example: EnforcedStyle: template

    # bad
    format('%<greeting>s', greeting: 'Hello')
    format('%s', 'Hello')
    
    # good
    format('%{greeting}', greeting: 'Hello')</greeting>

    Example: EnforcedStyle: unannotated

    # bad
    format('%<greeting>s', greeting: 'Hello')
    format('%{greeting}', 'Hello')
    
    # good
    format('%s', 'Hello')</greeting>

    Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
    Open

          if(s.length>0)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

    Example:

    # bad
    if condition
      do_stuff(bar)
    end
    
    unless qux.empty?
      Foo.do_something
    end
    
    # good
    do_stuff(bar) if condition
    Foo.do_something unless qux.empty?

    Redundant self detected.
    Open

        return self.mysql_execute('show tables')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Space missing after comma.
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Surrounding space missing for operator +=.
    Open

          dropsql +="drop table #{table};"
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that operators have space around them, except for ** which should not have surrounding space.

    Example:

    # bad
    total = 3*4
    "apple"+"juice"
    my_number = 38/4
    a ** b
    
    # good
    total = 3 * 4
    "apple" + "juice"
    my_number = 38 / 4
    a**b

    Line is too long. [88/80]
    Open

        cmd = "#{self.mysql_executable_dir}/#{exec} -u#{user} -h#{host} -p#{password} #{db}"
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Redundant return detected.
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

            s += " "
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
    "No special symbols"
    "No string interpolation"
    "Just text"
    
    # good
    'No special symbols'
    'No string interpolation'
    'Just text'
    "Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
    'Just some text'
    'No special chars or interpolation'
    
    # good
    "Just some text"
    "No special chars or interpolation"
    "Every string in #{project} uses double_quotes"

    Extra empty line detected at class body beginning.
    Open

    
      def self.mysql_executable_dir
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cops checks if empty lines around the bodies of classes match the configuration.

    Example: EnforcedStyle: empty_lines

    # good
    
    class Foo
    
      def bar
        # ...
      end
    
    end

    Example: EnforcedStyle: emptylinesexcept_namespace

    # good
    
    class Foo
      class Bar
    
        # ...
    
      end
    end

    Example: EnforcedStyle: emptylinesspecial

    # good
    class Foo
    
      def bar; end
    
    end

    Example: EnforcedStyle: noemptylines (default)

    # good
    
    class Foo
      def bar
        # ...
      end
    end

    Surrounding space missing in default value assignment.
    Open

      def self.create_mysql_base_command_with(user,host,password,db,exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

    Example:

    # bad
    def some_method(arg1=:default, arg2=nil, arg3=[])
      # do something...
    end
    
    # good
    def some_method(arg1 = :default, arg2 = nil, arg3 = [])
      # do something...
    end

    Surrounding space missing in default value assignment.
    Open

      def self.create_mysql_base_command(exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

    Example:

    # bad
    def some_method(arg1=:default, arg2=nil, arg3=[])
      # do something...
    end
    
    # good
    def some_method(arg1 = :default, arg2 = nil, arg3 = [])
      # do something...
    end

    Line is too long. [112/80]
    Open

        return self.create_mysql_base_command_with(fetch(:dbuser),fetch(:dbhost),fetch(:dbpass),fetch(:dbname),exec)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Avoid using {...} for multi-line blocks.
    Open

        Dir.foreach(TYPO3_DB_DUMP_DIR) {|sql|
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Check for uses of braces or do/end around single line or multi-line blocks.

    Example: EnforcedStyle: linecountbased (default)

    # bad - single line block
    items.each do |item| item / 5 end
    
    # good - single line block
    items.each { |item| item / 5 }
    
    # bad - multi-line block
    things.map { |thing|
      something = thing.some_method
      process(something)
    }
    
    # good - multi-line block
    things.map do |thing|
      something = thing.some_method
      process(something)
    end

    Example: EnforcedStyle: semantic

    # Prefer `do...end` over `{...}` for procedural blocks.
    
    # return value is used/assigned
    # bad
    foo = map do |x|
      x
    end
    puts (map do |x|
      x
    end)
    
    # return value is not used out of scope
    # good
    map do |x|
      x
    end
    
    # Prefer `{...}` over `do...end` for functional blocks.
    
    # return value is not used out of scope
    # bad
    each { |x|
      x
    }
    
    # return value is used/assigned
    # good
    foo = map { |x|
      x
    }
    map { |x|
      x
    }.inspect

    Example: EnforcedStyle: bracesforchaining

    # bad
    words.each do |word|
      word.flip.flop
    end.join("-")
    
    # good
    words.each { |word|
      word.flip.flop
    }.join("-")

    Use next to skip iteration.
    Open

          if File.extname(sql) == '.sql'
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Use next to skip iteration instead of a condition at the end.

    Example: EnforcedStyle: skipmodifierifs (default)

    # bad
    [1, 2].each do |a|
      if a == 1
        puts a
      end
    end
    
    # good
    [1, 2].each do |a|
      next unless a == 1
      puts a
    end
    
    # good
    [1, 2].each do |o|
      puts o unless o == 1
    end

    Example: EnforcedStyle: always

    # With `always` all conditions at the end of an iteration needs to be
    # replaced by next - with `skip_modifier_ifs` the modifier if like
    # this one are ignored: `[1, 2].each { |a| return 'yes' if a == 1 }`
    
    # bad
    [1, 2].each do |o|
      puts o unless o == 1
    end
    
    # bad
    [1, 2].each do |a|
      if a == 1
        puts a
      end
    end
    
    # good
    [1, 2].each do |a|
      next unless a == 1
      puts a
    end

    Redundant return detected.
    Open

        return s
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant return expressions.

    Example:

    def test
      return something
    end
    
    def test
      one
      two
      three
      return something
    end

    It should be extended to handle methods whose body is if/else or a case expression with a default branch.

    Redundant self detected.
    Open

        cmd = "#{self.mysql_executable_dir}/#{exec} -u#{user} -h#{host} -p#{password} #{db}"
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Extra empty line detected at method body beginning.
    Open

    
        filename =''
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cops checks if empty lines exist around the bodies of methods.

    Example:

    # good
    
    def foo
      # ...
    end
    
    # bad
    
    def bar
    
      # ...
    
    end

    Space missing after comma.
    Open

      def self.mysqldump_to(outputfile,excludelist=nil,no_schema=nil)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Useless assignment to variable - filename.
    Open

        filename =''
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

            image['time'] = File.mtime(sql).strftime("%Y-%m-%d %H:%M")
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
    "No special symbols"
    "No string interpolation"
    "Just text"
    
    # good
    'No special symbols'
    'No string interpolation'
    'Just text'
    "Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
    'Just some text'
    'No special chars or interpolation'
    
    # good
    "Just some text"
    "No special chars or interpolation"
    "Every string in #{project} uses double_quotes"

    Use !empty? instead of length > 0.
    Open

          if(s.length>0)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for numeric comparisons that can be replaced by a predicate method, such as receiver.length == 0, receiver.length > 0, receiver.length != 0, receiver.length < 1 and receiver.size == 0 that can be replaced by receiver.empty? and !receiver.empty.

    Example:

    # bad
    [1, 2, 3].length == 0
    0 == "foobar".length
    array.length < 1
    {a: 1, b: 2}.length != 0
    string.length > 0
    hash.size > 0
    
    # good
    [1, 2, 3].empty?
    "foobar".empty?
    array.empty?
    !{a: 1, b: 2}.empty?
    !string.empty?
    !hash.empty?

    Surrounding space missing in default value assignment.
    Open

      def self.dump_db_version(table_exclude_list=nil)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

    Example:

    # bad
    def some_method(arg1=:default, arg2=nil, arg3=[])
      # do something...
    end
    
    # good
    def some_method(arg1 = :default, arg2 = nil, arg3 = [])
      # do something...
    end

    Surrounding space missing for operator +.
    Open

            idx = idx+1
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks that operators have space around them, except for ** which should not have surrounding space.

    Example:

    # bad
    total = 3*4
    "apple"+"juice"
    my_number = 38/4
    a ** b
    
    # good
    total = 3 * 4
    "apple" + "juice"
    my_number = 38 / 4
    a**b

    Extra blank line detected.
    Open

    
            if(sql.split('.').count == 3)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cops checks for two or more consecutive blank lines.

    Example:

    # bad - It has two empty lines.
    some_method
    # one empty line
    # two empty lines
    some_method
    
    # good
    some_method
    # one empty line
    some_method

    Space missing after comma.
    Open

        DT3MySQL::mysqldump_to(filename,table_exclude_list)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Do not use :: for method calls.
    Open

        DT3MySQL::mysqldump_to(filename,table_exclude_list)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for methods invoked via the :: operator instead of the . operator (like FileUtils::rmdir instead of FileUtils.rmdir).

    Example:

    # bad
    Timeout::timeout(500) { do_something }
    FileUtils::rmdir(dir)
    Marshal::dump(obj)
    
    # good
    Timeout.timeout(500) { do_something }
    FileUtils.rmdir(dir)
    Marshal.dump(obj)

    Space missing after comma.
    Open

      def self.create_mysql_base_command_with(user,host,password,db,exec='mysql')
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Space after keyword if is missing.
    Open

            if(sql.split('.').count == 3)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks the spacing around the keywords.

    Example:

    # bad
    something 'test'do|x|
    end
    
    while(something)
    end
    
    something = 123if test
    
    # good
    something 'test' do |x|
    end
    
    while (something)
    end
    
    something = 123 if test

    Space after keyword if is missing.
    Open

          if(s.length>0)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks the spacing around the keywords.

    Example:

    # bad
    something 'test'do|x|
    end
    
    while(something)
    end
    
    something = 123if test
    
    # good
    something 'test' do |x|
    end
    
    while (something)
    end
    
    something = 123 if test

    Space after keyword if is missing.
    Open

        if(not excludelist.nil?)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    Checks the spacing around the keywords.

    Example:

    # bad
    something 'test'do|x|
    end
    
    while(something)
    end
    
    something = 123if test
    
    # good
    something 'test' do |x|
    end
    
    while (something)
    end
    
    something = 123 if test

    Use ! instead of not.
    Open

        if(not excludelist.nil?)
    Severity: Minor
    Found in lib/capistrano/typo3/dt3_mysql.rb by rubocop

    This cop checks for uses of the keyword not instead of !.

    Example:

    # bad - parentheses are required because of op precedence
    x = (not something)
    
    # good
    x = !something

    There are no issues that match your filters.

    Category
    Status