takuseno/mvc-drl

View on GitHub
mvc/interaction.py

Summary

Maintainability
A
1 hr
Test Coverage

Function loop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def loop(env, view, hook=None):
    while True:
        obs, reward, done, info = env.reset(), 0.0, False, {}
        while not done:
            obs, reward, done, info = step(env, view, obs, reward, done, info)
Severity: Minor
Found in mvc/interaction.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function interact has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def interact(env, view, eval_env=None, eval_view=None, hook=None, batch=False):
    _loop = batch_loop if batch else loop

    def _hook(view):
        if eval_view is not None and view.should_eval():
Severity: Minor
Found in mvc/interaction.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status