Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/profile/ManageRoles.js

Summary

Maintainability
D
2 days
Test Coverage

Function constructor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor: function(config){
    this.roles_control = new Talho.ux.RolesControl(config.url + ".json", this);

    this.infobox = new Ext.Container({
      layout: 'column',
Severity: Minor
Found in app/assets/javascripts/profile/ManageRoles.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    Talho.ManageRoles = Ext.extend(Talho.ProfileBase, {
  constructor: function(config){
    this.roles_control = new Talho.ux.RolesControl(config.url + ".json", this);

    this.infobox = new Ext.Container({
    Severity: Major
    Found in app/assets/javascripts/profile/ManageRoles.js and 1 other location - About 2 days to fix
    app/assets/javascripts/profile/ManageOrganizations.js on lines 6..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 408.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    Talho.ManageRoles.initialize = function(config){
  var o = new Talho.ManageRoles(config);
  return o.getPanel();
};
    Severity: Major
    Found in app/assets/javascripts/profile/ManageRoles.js and 14 other locations - About 35 mins to fix
    app/assets/javascripts/admin/AddUser.js on lines 83..86
    app/assets/javascripts/admin/AuditLog.js on lines 236..239
    app/assets/javascripts/admin/BatchUsers.js on lines 213..216
    app/assets/javascripts/admin/EditUsers.js on lines 182..185
    app/assets/javascripts/admin/PendingRoleRequests.js on lines 40..43
    app/assets/javascripts/dashboard/tutorials.js on lines 35..39
    app/assets/javascripts/documents/Documents.js on lines 491..494
    app/assets/javascripts/invitations/Invitations.js on lines 413..416
    app/assets/javascripts/invitations/NewInvitation.js on lines 305..308
    app/assets/javascripts/profile/EditDevices.js on lines 47..50
    app/assets/javascripts/profile/EditPassword.js on lines 24..27
    app/assets/javascripts/profile/EditProfile.js on lines 139..142
    app/assets/javascripts/profile/ManageOrganizations.js on lines 48..51
    app/assets/javascripts/searches/AdvancedSearch.js on lines 98..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status