tasafo/palestras-coletivas

View on GitHub
app/presenters/schedule_presenter.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

SchedulePresenter#prepare_dates has approx 7 statements
Open

  def prepare_dates(event_dates, schedule)
Severity: Minor
Found in app/presenters/schedule_presenter.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

SchedulePresenter#prepare_dates doesn't depend on instance state (maybe move it to another class?)
Open

  def prepare_dates(event_dates, schedule)
Severity: Minor
Found in app/presenters/schedule_presenter.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

There are no issues that match your filters.

Category
Status