taye/interact.js

View on GitHub
packages/core/Interaction.ts

Summary

Maintainability
D
1 day
Test Coverage

File Interaction.ts has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as utils from '@interactjs/utils'
import Interactable from './Interactable'
import InteractEvent, { EventPhase } from './InteractEvent'
import PointerInfo from './PointerInfo'
import { ActionName } from './scope'
Severity: Minor
Found in packages/core/Interaction.ts - About 3 hrs to fix

    Interaction has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class Interaction<T extends ActionName = any> {
      // current interactable being interacted with
      interactable: Interactable = null
    
      // the target element of the interactable
    Severity: Minor
    Found in packages/core/Interaction.ts - About 2 hrs to fix

      Function updatePointer has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        updatePointer (pointer: Interact.PointerType, event: Interact.PointerEventType, eventTarget: EventTarget, down?: boolean) {
          const id = utils.pointer.getPointerId(pointer)
          let pointerIndex = this.getPointerIndex(pointer)
          let pointerInfo = this.pointers[pointerIndex]
      
      
      Severity: Minor
      Found in packages/core/Interaction.ts - About 1 hr to fix

        Function pointerMove has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          pointerMove (pointer: Interact.PointerType, event: Interact.PointerEventType, eventTarget: EventTarget) {
            if (!this.simulation) {
              this.updatePointer(pointer, event, eventTarget, false)
              utils.pointer.setCoords(this.coords.cur, this.pointers.map((p) => p.pointer), this._now())
            }
        Severity: Minor
        Found in packages/core/Interaction.ts - About 1 hr to fix

          Function _doPhase has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            _doPhase (signalArg: Partial<Interact.SignalArg>) {
              const { event, phase, preEnd, type } = signalArg
              const beforeResult = this._signals.fire(`before-action-${phase}`, signalArg)
          
              if (beforeResult === false) {
          Severity: Minor
          Found in packages/core/Interaction.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function pointerMove has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            pointerMove (pointer: Interact.PointerType, event: Interact.PointerEventType, eventTarget: EventTarget) {
              if (!this.simulation) {
                this.updatePointer(pointer, event, eventTarget, false)
                utils.pointer.setCoords(this.coords.cur, this.pointers.map((p) => p.pointer), this._now())
              }
          Severity: Minor
          Found in packages/core/Interaction.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updatePointer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            updatePointer (pointer: Interact.PointerType, event: Interact.PointerEventType, eventTarget: EventTarget, down?: boolean) {
              const id = utils.pointer.getPointerId(pointer)
              let pointerIndex = this.getPointerIndex(pointer)
              let pointerInfo = this.pointers[pointerIndex]
          
          
          Severity: Minor
          Found in packages/core/Interaction.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                utils.pointer.setCoords(this.coords.cur, this.pointers.map((p) => p.pointer), this._now())
          Severity: Minor
          Found in packages/core/Interaction.ts and 1 other location - About 50 mins to fix
          packages/core/Interaction.ts on lines 404..404

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  utils.pointer.setCoords(this.coords.start, this.pointers.map((p) => p.pointer), this._now())
          Severity: Minor
          Found in packages/core/Interaction.ts and 1 other location - About 50 mins to fix
          packages/core/Interaction.ts on lines 197..197

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this._signals.fire('remove-pointer', {
                pointer,
                event,
                pointerIndex,
                pointerInfo,
          Severity: Minor
          Found in packages/core/Interaction.ts and 1 other location - About 45 mins to fix
          packages/core/Interaction.ts on lines 131..137

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this._signals.fire('down', {
                pointer,
                event,
                eventTarget,
                pointerIndex,
          Severity: Minor
          Found in packages/core/Interaction.ts and 1 other location - About 45 mins to fix
          packages/core/Interaction.ts on lines 440..446

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status