taye/interact.js

View on GitHub
packages/modifiers/base.ts

Summary

Maintainability
D
1 day
Test Coverage

File base.ts has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Scope } from '@interactjs/core/scope'
import extend from '@interactjs/utils/extend'

declare module '@interactjs/core/scope' {
  interface Scope {
Severity: Minor
Found in packages/modifiers/base.ts - About 4 hrs to fix

    Function setAll has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function setAll (arg: Partial<Interact.SignalArg>) {
      const {
        interaction,
        modifiersState = interaction.modifiers,
        prevCoords = modifiersState.result
    Severity: Major
    Found in packages/modifiers/base.ts - About 2 hrs to fix

      Function makeModifier has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function makeModifier<Options extends { [key: string]: any }> (module: { defaults: Options, [key: string]: any }, name?: string) {
        const { defaults } = module
        const methods = {
          start: module.start,
          set: module.set,
      Severity: Minor
      Found in packages/modifiers/base.ts - About 1 hr to fix

        Function install has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function install (scope: Scope) {
          const {
            interactions,
          } = scope
        
        
        Severity: Minor
        Found in packages/modifiers/base.ts - About 1 hr to fix

          Function setAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          export function setAll (arg: Partial<Interact.SignalArg>) {
            const {
              interaction,
              modifiersState = interaction.modifiers,
              prevCoords = modifiersState.result
          Severity: Minor
          Found in packages/modifiers/base.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function beforeEnd has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function beforeEnd (arg): void | false {
            const { interaction, event, noPreEnd } = arg
            const states = interaction.modifiers.states
          
            if (noPreEnd || !states || !states.length) {
          Severity: Minor
          Found in packages/modifiers/base.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function shouldDo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function shouldDo (options, preEnd?: boolean, requireEndOnly?: boolean, phase?: string) {
            return options
              ? options.enabled !== false &&
                (preEnd || !options.endOnly) &&
                (!requireEndOnly || options.endOnly || options.alwaysOnEnd) &&
          Severity: Minor
          Found in packages/modifiers/base.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function makeModifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function makeModifier<Options extends { [key: string]: any }> (module: { defaults: Options, [key: string]: any }, name?: string) {
            const { defaults } = module
            const methods = {
              start: module.start,
              set: module.set,
          Severity: Minor
          Found in packages/modifiers/base.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            for (const [coordsSet, delta] of [[startCoords, startDelta], [curCoords, curDelta]]) {
              coordsSet.page.x   += delta.x
              coordsSet.page.y   += delta.y
              coordsSet.client.x += delta.x
              coordsSet.client.y += delta.y
          Severity: Major
          Found in packages/modifiers/base.ts and 1 other location - About 2 hrs to fix
          packages/modifiers/base.ts on lines 361..366

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            for (const [coordsSet, delta] of [[coords.start, startDelta], [coords.cur, curDelta]]) {
              coordsSet.page.x -= delta.x
              coordsSet.page.y -= delta.y
              coordsSet.client.x -= delta.x
              coordsSet.client.y -= delta.y
          Severity: Major
          Found in packages/modifiers/base.ts and 1 other location - About 2 hrs to fix
          packages/modifiers/base.ts on lines 336..341

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Wontfix

              ? {
                left  : coords.x - rect.left,
                top   : coords.y - rect.top,
                right : rect.right  - coords.x,
                bottom: rect.bottom - coords.y,
          Severity: Major
          Found in packages/modifiers/base.ts and 2 other locations - About 1 hr to fix
          packages/inertia/index.ts on lines 364..369
          packages/modifiers/restrict/edges.ts on lines 34..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status