tewarid/node-tcp-proxy

View on GitHub

Showing 5 of 5 total issues

Function handleAuth has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

TcpProxy.prototype.handleAuth = function(proxySocket) {
    var self = this;
    if (self.allowedIPs.includes(proxySocket.remoteAddress)) {
        self.handleClient(proxySocket);
        return;
Severity: Minor
Found in tcp-proxy.js - About 1 hr to fix

    Function TcpProxy has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function TcpProxy(proxyPort, serviceHost, servicePort, options) {
        this.proxyPort = proxyPort;
        this.serviceHosts = parse(serviceHost);
        this.servicePorts = parse(servicePort);
        this.serviceHostIndex = -1;
    Severity: Minor
    Found in tcp-proxy.js - About 1 hr to fix

      Function createServiceSocket has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      TcpProxy.prototype.createServiceSocket = function(context) {
          var self = this;
          var options = self.parseServiceOptions(context);
          if (self.options.tls === "both") {
              context.serviceSocket = tls.connect(options, function() {
      Severity: Minor
      Found in tcp-proxy.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            context.serviceSocket.on("close", function(hadError) {
                if (context.proxySocket !== undefined) {
                    context.proxySocket.destroy();
                }
            });
        Severity: Minor
        Found in tcp-proxy.js and 1 other location - About 50 mins to fix
        tcp-proxy.js on lines 193..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            context.serviceSocket.on("error", function(e) {
                if (context.proxySocket !== undefined) {
                    context.proxySocket.destroy();
                }
            });
        Severity: Minor
        Found in tcp-proxy.js and 1 other location - About 50 mins to fix
        tcp-proxy.js on lines 188..192

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language