the-rocci-project/rOCCI-server

View on GitHub

Showing 31 of 31 total issues

Class BackendProxy has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class BackendProxy
  # Available backend fragments (supported types of resources)
  BACKEND_RESOURCE_SUBTYPES = %i[
    compute network storage securitygroup ipreservation
  ].freeze
Severity: Minor
Found in app/models/backend_proxy.rb - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            ATTRIBUTES_CORE = {
              'occi.core.id' => ->(ary) { "compute_#{ary.last['ID']}_nic_#{ary.first['NIC_ID']}" },
              'occi.core.title' => ->(ary) { "NIC #{ary.first['NIC_ID']} for compute #{ary.last['ID']}" },
              'occi.core.source' => ->(ary) { URI.parse("/compute/#{ary.last['ID']}") },
              'occi.core.target' => ->(ary) { URI.parse("/network/#{ary.first['NETWORK_ID']}") }
    Severity: Major
    Found in app/lib/backends/opennebula/constants/networkinterface.rb and 1 other location - About 1 hr to fix
    app/lib/backends/opennebula/constants/storagelink.rb on lines 12..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            ATTRIBUTES_CORE = {
              'occi.core.id' => ->(ary) { "compute_#{ary.last['ID']}_disk_#{ary.first['DISK_ID']}" },
              'occi.core.title' => ->(ary) { "DISK #{ary.first['DISK_ID']} for compute #{ary.last['ID']}" },
              'occi.core.source' => ->(ary) { URI.parse("/compute/#{ary.last['ID']}") },
              'occi.core.target' => ->(ary) { URI.parse("/storage/#{ary.first['IMAGE_ID']}") }
    Severity: Major
    Found in app/lib/backends/opennebula/constants/storagelink.rb and 1 other location - About 1 hr to fix
    app/lib/backends/opennebula/constants/networkinterface.rb on lines 11..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def instance(identifier)
            logger.debug { "#{self.class}: Getting instance with ID #{identifier}" }
            matched = Constants::Networkinterface::ID_PATTERN.match(identifier)
            vm = pool_element(:virtual_machine, matched[:compute], :info)
    
    
    Severity: Major
    Found in app/lib/backends/opennebula/networkinterface.rb and 1 other location - About 1 hr to fix
    app/lib/backends/opennebula/storagelink.rb on lines 46..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def instance(identifier)
            logger.debug { "#{self.class}: Getting instance with ID #{identifier}" }
            matched = Constants::Storagelink::ID_PATTERN.match(identifier)
            vm = pool_element(:virtual_machine, matched[:compute], :info)
    
    
    Severity: Major
    Found in app/lib/backends/opennebula/storagelink.rb and 1 other location - About 1 hr to fix
    app/lib/backends/opennebula/networkinterface.rb on lines 46..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method transfer_attributes! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def transfer_attributes!(source, target, mappers)
            raise Errors::Backend::InternalError, '`mappers` must be enumerable' unless mappers.is_a? Enumerable
            unless target.respond_to?(:[]=) && target.respond_to?(:attributes)
              raise Errors::Backend::InternalError, '`target` must be Entity-like'
            end
    Severity: Minor
    Found in app/lib/backends/helpers/attributes_transferable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def identifiers(filter = Set.new)
            logger.debug { "#{self.class}: Listing identifiers with filter #{filter.inspect}" }
            sls = Set.new
            pool(:virtual_machine, :info_mine).each do |vm|
              vm.each('TEMPLATE/DISK') do |disk|
    Severity: Minor
    Found in app/lib/backends/opennebula/storagelink.rb and 1 other location - About 50 mins to fix
    app/lib/backends/opennebula/networkinterface.rb on lines 24..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def identifiers(filter = Set.new)
            logger.debug { "#{self.class}: Listing identifiers with filter #{filter.inspect}" }
            nis = Set.new
            pool(:virtual_machine, :info_mine).each do |vm|
              vm.each('TEMPLATE/NIC') do |nic|
    Severity: Minor
    Found in app/lib/backends/opennebula/networkinterface.rb and 1 other location - About 50 mins to fix
    app/lib/backends/opennebula/storagelink.rb on lines 24..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    module Backends
      module Dummy
        class Storagelink < EntityBase
          class << self
            # @see `served_class` on `Entitylike`
    Severity: Major
    Found in app/lib/backends/dummy/storagelink.rb and 2 other locations - About 45 mins to fix
    app/lib/backends/dummy/networkinterface.rb on lines 3..26
    app/lib/backends/dummy/securitygrouplink.rb on lines 3..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    module Backends
      module Dummy
        class Networkinterface < EntityBase
          class << self
            # @see `served_class` on `Entitylike`
    Severity: Major
    Found in app/lib/backends/dummy/networkinterface.rb and 2 other locations - About 45 mins to fix
    app/lib/backends/dummy/securitygrouplink.rb on lines 3..26
    app/lib/backends/dummy/storagelink.rb on lines 3..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    module Backends
      module Dummy
        class Securitygrouplink < EntityBase
          class << self
            # @see `served_class` on `Entitylike`
    Severity: Major
    Found in app/lib/backends/dummy/securitygrouplink.rb and 2 other locations - About 45 mins to fix
    app/lib/backends/dummy/networkinterface.rb on lines 3..26
    app/lib/backends/dummy/storagelink.rb on lines 3..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method client has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def client(e_klass)
            raise Errors::Backend::InternalError, 'Block is a mandatory argument for client calls' unless block_given?
            if ERROR_CONNECT.include?(e_klass)
              raise Errors::Backend::InternalError, "Error #{e_klass} cannot be used with this wrapper"
            end
    Severity: Minor
    Found in app/lib/backends/opennebula/base.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_floatingippools! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_floatingippools!(model, skeleton)
            pool(:virtual_network, :info_all).each do |vnet|
              next if vnet['PARENT_NETWORK_ID'].present? || vnet['TEMPLATE/FLOATING_IP_POOL'].blank?
              next unless vnet['TEMPLATE/FLOATING_IP_POOL'].casecmp('yes')
    
    
    Severity: Minor
    Found in app/lib/backends/opennebula/model_extender.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def list(filter = Set.new)
            logger.debug { "#{self.class}: Listing instances with filter #{filter.inspect}" }
            coll = Occi::Core::Collection.new
            pool(:virtual_machine, :info_mine).each do |vm|
              vm.each('TEMPLATE/DISK') { |disk| coll << storagelink_from(disk, vm) }
    Severity: Minor
    Found in app/lib/backends/opennebula/storagelink.rb and 1 other location - About 40 mins to fix
    app/lib/backends/opennebula/networkinterface.rb on lines 36..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def list(filter = Set.new)
            logger.debug { "#{self.class}: Listing instances with filter #{filter.inspect}" }
            coll = Occi::Core::Collection.new
            pool(:virtual_machine, :info_mine).each do |vm|
              vm.each('TEMPLATE/NIC') { |nic| coll << networkinterface_from(nic, vm) }
    Severity: Minor
    Found in app/lib/backends/opennebula/networkinterface.rb and 1 other location - About 40 mins to fix
    app/lib/backends/opennebula/storagelink.rb on lines 36..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method read_decrypted has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def read_decrypted(token)
          return unless token
    
          parts = token.split(INTERNAL_TOKEN_SEPARATOR)
          if parts.count != 2 || parts[0].blank? || parts[1].blank?
    Severity: Minor
    Found in lib/rack/tokenator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method resource_tpl_by_size has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def resource_tpl_by_size(virtual_machine, comparable_attributes)
            return unless virtual_machine
    
            server_model.find_resource_tpls.detect do |resource_tpl|
              comparable_attributes.reduce(true) do |match, (key, val)|
    Severity: Minor
    Found in app/lib/backends/helpers/resource_tpl_locatable.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def delete(identifier)
            logger.debug { "#{self.class}: Deleting instance #{identifier}" }
            matched = Constants::Networkinterface::ID_PATTERN.match(identifier)
            vm = pool_element(:virtual_machine, matched[:compute])
            client(Errors::Backend::EntityActionError) { vm.nic_detach(matched[:nic].to_i) }
    Severity: Minor
    Found in app/lib/backends/opennebula/networkinterface.rb and 1 other location - About 35 mins to fix
    app/lib/backends/opennebula/storagelink.rb on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def delete(identifier)
            logger.debug { "#{self.class}: Deleting instance #{identifier}" }
            matched = Constants::Storagelink::ID_PATTERN.match(identifier)
            vm = pool_element(:virtual_machine, matched[:compute])
            client(Errors::Backend::EntityActionError) { vm.disk_detach(matched[:disk].to_i) }
    Severity: Minor
    Found in app/lib/backends/opennebula/storagelink.rb and 1 other location - About 35 mins to fix
    app/lib/backends/opennebula/networkinterface.rb on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          def list(filter = Set.new)
            logger.debug { "#{self.class}: Listing instances with filter #{filter.inspect}" }
            coll = Occi::Core::Collection.new
            pool(:virtual_machine, :info_mine).each { |vm| coll << compute_from(vm) }
            coll
    Severity: Minor
    Found in app/lib/backends/opennebula/compute.rb and 2 other locations - About 30 mins to fix
    app/lib/backends/opennebula/securitygroup.rb on lines 30..34
    app/lib/backends/opennebula/storage.rb on lines 31..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language