theforeman/foreman

View on GitHub
app/controllers/api/v2/compute_resources_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class ComputeResourcesController has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ComputeResourcesController < V2::BaseController
      include Api::Version2
      include Foreman::Controller::Parameters::ComputeResource

      wrap_parameters ComputeResource, :include => compute_resource_params_filter.accessible_attributes(parameter_filter_context)
Severity: Minor
Found in app/controllers/api/v2/compute_resources_controller.rb - About 2 hrs to fix

    File compute_resources_controller.rb has 253 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Api
      module V2
        class ComputeResourcesController < V2::BaseController
          include Api::Version2
          include Foreman::Controller::Parameters::ComputeResource
    Severity: Minor
    Found in app/controllers/api/v2/compute_resources_controller.rb - About 2 hrs to fix

      Method power_vm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def power_vm
              @vm = @compute_resource.find_vm_by_uuid(params[:vm_id])
              action = @vm.ready? ? :stop : :start
              @vm.send(action)
              render_message(_('%{action} %{vm}') % {:vm => @vm, :action => (action == :stop) ? _('stopping') : _('starting')})
      Severity: Minor
      Found in app/controllers/api/v2/compute_resources_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def available_storage_domains
              if params[:storage_domain]
                Foreman::Deprecation.api_deprecation_warning("use /compute_resources/:id/storage_domain/:storage_domain_id endpoind instead")
                @available_storage_domains = [@compute_resource.storage_domain(params[:storage_domain])]
              else
      Severity: Minor
      Found in app/controllers/api/v2/compute_resources_controller.rb and 1 other location - About 30 mins to fix
      app/controllers/api/v2/compute_resources_controller.rb on lines 194..203

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def available_storage_pods
              if params[:storage_pod]
                Foreman::Deprecation.api_deprecation_warning("use /compute_resources/:id/storage_pod/:storage_pod_id endpoind instead")
                @available_storage_pods = [@compute_resource.storage_pod(params[:storage_pod])]
              else
      Severity: Minor
      Found in app/controllers/api/v2/compute_resources_controller.rb and 1 other location - About 30 mins to fix
      app/controllers/api/v2/compute_resources_controller.rb on lines 170..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status