Sign upLogin

theforeman/foreman_salt

View on GitHub
Star

Showing 40 of 40 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['zh_CN'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js and 5 other locations - About 1 wk to fix
app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js on lines 1..556

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1350.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['de'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js and 5 other locations - About 1 wk to fix
app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js on lines 1..556

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1350.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['ja'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js and 5 other locations - About 1 wk to fix
app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js on lines 1..556

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1350.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['ka'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js and 5 other locations - About 1 wk to fix
app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js on lines 1..556

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1350.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['en'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js and 5 other locations - About 1 wk to fix
app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js on lines 1..556

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1350.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['fr'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js and 5 other locations - About 1 wk to fix
app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js on lines 1..556
app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js on lines 1..556

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1350.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['ka'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js - About 1 day to fix

    File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

     locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['de'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
    Severity: Major
    Found in app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js - About 1 day to fix

      File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

       locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['ja'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
      Severity: Major
      Found in app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js - About 1 day to fix

        File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

         locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['zh_CN'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
        Severity: Major
        Found in app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js - About 1 day to fix

          File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

           locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['en'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
          Severity: Major
          Found in app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js - About 1 day to fix

            File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

             locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['fr'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
            Severity: Major
            Found in app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js - About 1 day to fix

              Method calculate_metrics has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  def calculate_metrics
      success = 0
      failed = 0
      changed = 0
      restarted = 0
              Severity: Minor
              Found in app/services/foreman_salt/report_importer.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method fetch_states_from_proxy has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  def fetch_states_from_proxy(proxy, environments = nil)
      result = { changes: {},
                 deletes: [] }

      new = ProxyAPI::Salt.new(url: proxy.url).states_list
              Severity: Minor
              Found in app/controllers/foreman_salt/state_importer.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method calculate_metrics has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def calculate_metrics
      success = 0
      failed = 0
      changed = 0
      restarted = 0
              Severity: Minor
              Found in app/services/foreman_salt/report_importer.rb - About 1 hr to fix

                Method apply_changes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                    def apply_changes
      if params[:changed].blank?
        info _('No changes found')
      else
        params[:changed].each do |environment, states|
                Severity: Minor
                Found in app/controllers/foreman_salt/salt_modules_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method import has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                        def import
          states = fetch_states_from_proxy(@proxy, params[:salt_environments])

          unless params[:dryrun]
            states[:changes].each do |environment, state|
                Severity: Minor
                Found in app/controllers/foreman_salt/api/v2/salt_states_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method import_log_messages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    def import_log_messages
      @raw.each do |resource, result|
        level = if result['changes'].blank? && result['result']
                  :info
                elsif result['result'] == false
                Severity: Minor
                Found in app/services/foreman_salt/report_importer.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function update_salt_states has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function update_salt_states(element) {
  var host_id = $("form").data('id');
  var env_id = $('select[name*=salt_environment_id]').val();
  var url = $(element).attr('data-url');
  var data = $("form").serialize().replace('method=put', 'method=post');
                Severity: Minor
                Found in app/assets/javascripts/foreman_salt/states.js - About 1 hr to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      def reject
      @proxy = find_proxy(:edit_smart_proxies_salt_keys)
      key = SmartProxies::SaltKeys.find(@proxy, params[:salt_key_id])
      if key.reject
        process_success(success_redirect: hash_for_smart_proxy_salt_keys_path(state: params[:state], expire_cache: true),
                  Severity: Major
                  Found in app/controllers/foreman_salt/salt_keys_controller.rb and 2 other locations - About 55 mins to fix
                  app/controllers/foreman_salt/salt_keys_controller.rb on lines 15..22
                  app/controllers/foreman_salt/salt_keys_controller.rb on lines 37..44

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language