theforeman/foreman_salt

View on GitHub

Showing 18 of 40 total issues

File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
Open

 locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['zh_CN'] = {
  "domain": "foreman_salt",
  "locale_data": {
    "foreman_salt": {
      "": {
Severity: Major
Found in app/assets/javascripts/foreman_salt/locale/zh_CN/foreman_salt.js - About 1 day to fix

    File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

     locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['ja'] = {
      "domain": "foreman_salt",
      "locale_data": {
        "foreman_salt": {
          "": {
    Severity: Major
    Found in app/assets/javascripts/foreman_salt/locale/ja/foreman_salt.js - About 1 day to fix

      File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

       locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['de'] = {
        "domain": "foreman_salt",
        "locale_data": {
          "foreman_salt": {
            "": {
      Severity: Major
      Found in app/assets/javascripts/foreman_salt/locale/de/foreman_salt.js - About 1 day to fix

        File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

         locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['fr'] = {
          "domain": "foreman_salt",
          "locale_data": {
            "foreman_salt": {
              "": {
        Severity: Major
        Found in app/assets/javascripts/foreman_salt/locale/fr/foreman_salt.js - About 1 day to fix

          File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

           locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['ka'] = {
            "domain": "foreman_salt",
            "locale_data": {
              "foreman_salt": {
                "": {
          Severity: Major
          Found in app/assets/javascripts/foreman_salt/locale/ka/foreman_salt.js - About 1 day to fix

            File foreman_salt.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

             locales['foreman_salt'] = locales['foreman_salt'] || {}; locales['foreman_salt']['en'] = {
              "domain": "foreman_salt",
              "locale_data": {
                "foreman_salt": {
                  "": {
            Severity: Major
            Found in app/assets/javascripts/foreman_salt/locale/en/foreman_salt.js - About 1 day to fix

              Method calculate_metrics has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  def calculate_metrics
                    success = 0
                    failed = 0
                    changed = 0
                    restarted = 0
              Severity: Minor
              Found in app/services/foreman_salt/report_importer.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method fetch_states_from_proxy has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  def fetch_states_from_proxy(proxy, environments = nil)
                    result = { changes: {},
                               deletes: [] }
              
                    new = ProxyAPI::Salt.new(url: proxy.url).states_list
              Severity: Minor
              Found in app/controllers/foreman_salt/state_importer.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method calculate_metrics has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def calculate_metrics
                    success = 0
                    failed = 0
                    changed = 0
                    restarted = 0
              Severity: Minor
              Found in app/services/foreman_salt/report_importer.rb - About 1 hr to fix

                Method apply_changes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                    def apply_changes
                      if params[:changed].blank?
                        info _('No changes found')
                      else
                        params[:changed].each do |environment, states|
                Severity: Minor
                Found in app/controllers/foreman_salt/salt_modules_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method import has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                        def import
                          states = fetch_states_from_proxy(@proxy, params[:salt_environments])
                
                          unless params[:dryrun]
                            states[:changes].each do |environment, state|
                Severity: Minor
                Found in app/controllers/foreman_salt/api/v2/salt_states_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method import_log_messages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    def import_log_messages
                      @raw.each do |resource, result|
                        level = if result['changes'].blank? && result['result']
                                  :info
                                elsif result['result'] == false
                Severity: Minor
                Found in app/services/foreman_salt/report_importer.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function update_salt_states has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function update_salt_states(element) {
                  var host_id = $("form").data('id');
                  var env_id = $('select[name*=salt_environment_id]').val();
                  var url = $(element).attr('data-url');
                  var data = $("form").serialize().replace('method=put', 'method=post');
                Severity: Minor
                Found in app/assets/javascripts/foreman_salt/states.js - About 1 hr to fix

                  Method load_ajax_vars has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def load_ajax_vars
                        @minion = Host::Base.authorized(:view_hosts, Host).find_by(id: params[:host_id])
                        if @minion
                          unless @minion.is_a?(Host::Managed)
                            @minion      = @minion.becomes(Host::Managed)
                  Severity: Minor
                  Found in app/controllers/foreman_salt/minions_controller.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method node has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def node
                        enc = {}
                        env = @minion.salt_environment.blank? ? 'base' : @minion.salt_environment.name
                        enc['classes'] = @minion.salt_modules_for_enc
                  
                  
                  Severity: Minor
                  Found in app/controllers/foreman_salt/minions_controller.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method salt_modules_in_host_environment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def salt_modules_in_host_environment
                          return unless salt_modules.any?
                  
                          if salt_environment
                            errors.add(:base, _('Salt states must be in the environment of the host')) unless (salt_modules - salt_environment.salt_modules).empty?
                  Severity: Minor
                  Found in app/models/foreman_salt/concerns/host_managed_extensions.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method load_vars_for_ajax has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def load_vars_for_ajax
                            return unless @host
                  
                            @obj                    = @host
                            @salt_environment       = @host.salt_environment if @host
                  Severity: Minor
                  Found in app/controllers/foreman_salt/concerns/hosts_controller_extensions.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method derive_salt_grains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def derive_salt_grains(use_autosign: false)
                          grains = {}
                          begin
                            Rails.logger.info('Derive Salt Grains from host_params and autosign_key')
                            grains[autosign_grain_name] = salt_autosign_key if use_autosign && !salt_autosign_key.nil?
                  Severity: Minor
                  Found in app/models/foreman_salt/concerns/host_managed_extensions.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language