thepracticaldev/dev.to

View on GitHub
app/javascript/listings/listingForm.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function render has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const {
      id,
      title,
      bodyMarkdown,
Severity: Major
Found in app/javascript/listings/listingForm.jsx - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const selectOrg =
          organizations && organizations.length > 0 ? (
            <OrgSettings
              organizations={organizations}
              organizationId={organizationId}
    Severity: Major
    Found in app/javascript/listings/listingForm.jsx and 1 other location - About 1 hr to fix
    app/javascript/article-form/articleForm.jsx on lines 349..358

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      handleOrgIdChange = e => {
        const organizationId = e.target.selectedOptions[0].value;
        this.setState({ organizationId });
      };
    Severity: Minor
    Found in app/javascript/listings/listingForm.jsx and 1 other location - About 50 mins to fix
    app/javascript/article-form/articleForm.jsx on lines 197..200

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status