thepracticaldev/dev.to

View on GitHub

Showing 201 of 419 total issues

File chat.jsx has 923 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { h, Component } from 'preact';
import PropTypes from 'prop-types';
import ConfigImage from 'images/three-dots.svg';
import {
  conductModeration,
Severity: Major
Found in app/javascript/chat/chat.jsx - About 2 days to fix

    Class User has 82 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class User < ApplicationRecord
      include CloudinaryHelper
    
      attr_accessor(
        :scholar_email, :new_note, :note_for_current_role, :user_status, :pro, :merge_user_id,
    Severity: Major
    Found in app/models/user.rb - About 1 day to fix

      Function render has 234 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
          const {
            listings,
            query,
            tags,
      Severity: Major
      Found in app/javascript/listings/listings.jsx - About 1 day to fix

        Function render has 226 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
            const { user} = this.props;
            const channelId = this.props.activeChannelId;
            const channel = this.props.activeChannel || {};
            const socialIcons = [];
        Severity: Major
        Found in app/javascript/chat/userDetails.jsx - About 1 day to fix

          File user.rb has 525 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          class User < ApplicationRecord
            include CloudinaryHelper
          
            attr_accessor(
              :scholar_email, :new_note, :note_for_current_role, :user_status, :pro, :merge_user_id,
          Severity: Major
          Found in app/models/user.rb - About 1 day to fix

            Function initializePodcastPlayback has 213 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function initializePodcastPlayback() {
            
              function getById(name) {
                return document.getElementById(name);
              }
            Severity: Major
            Found in app/assets/javascripts/initializers/initializePodcastPlayback.js - About 1 day to fix

              File article.rb has 520 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              class Article < ApplicationRecord
                include CloudinaryHelper
                include ActionView::Helpers
                include AlgoliaSearch
                include Storext.model
              Severity: Major
              Found in app/models/article.rb - About 1 day to fix

                File listings.jsx has 500 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import { h, Component } from 'preact';
                import { SingleListing } from './singleListing';
                
                export class Listings extends Component {
                  state = {
                Severity: Minor
                Found in app/javascript/listings/listings.jsx - About 1 day to fix

                  Class Article has 56 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Article < ApplicationRecord
                    include CloudinaryHelper
                    include ActionView::Helpers
                    include AlgoliaSearch
                    include Storext.model
                  Severity: Major
                  Found in app/models/article.rb - About 1 day to fix

                    Function render has 175 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      render() {
                        // cover image url should asking for url OR providing option to upload an image
                        const {
                          title,
                          tagList,
                    Severity: Major
                    Found in app/javascript/article-form/articleForm.jsx - About 7 hrs to fix

                      File Onboarding.jsx has 445 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      import { h, render, Component } from 'preact';
                      import OnboardingWelcome from './components/OnboardingWelcome';
                      import OnboardingFollowTags from './components/OnboardingFollowTags';
                      import OnboardingFollowUsers from './components/OnboardingFollowUsers';
                      import OnboardingWelcomeThread from './components/OnboardingWelcomeThread';
                      Severity: Minor
                      Found in app/javascript/src/Onboarding.jsx - About 6 hrs to fix

                        Chat has 47 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        export default class Chat extends Component {
                          static propTypes = {
                            pusherKey: PropTypes.number.isRequired,
                            chatChannels: PropTypes.array.isRequired,
                            chatOptions: PropTypes.object.isRequired,
                        Severity: Minor
                        Found in app/javascript/chat/chat.jsx - About 6 hrs to fix

                          File articleForm.jsx has 429 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          import 'preact/devtools';
                          import { h, Component } from 'preact';
                          import linkState from 'linkstate';
                          import postscribe from 'postscribe';
                          import ImageUploadIcon from 'images/image-upload.svg';
                          Severity: Minor
                          Found in app/javascript/article-form/articleForm.jsx - About 6 hrs to fix

                            Function initializePodcastPlayback has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function initializePodcastPlayback() {
                            
                              function getById(name) {
                                return document.getElementById(name);
                              }
                            Severity: Minor
                            Found in app/assets/javascripts/initializers/initializePodcastPlayback.js - About 6 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function render has 134 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              render() {
                                const channel = this.props.channel; // eslint-disable-line
                                const users = Object.values(channel.channel_users).map(user => (
                                  <div className="channeldetails__user">
                                    <img
                            Severity: Major
                            Found in app/javascript/chat/channelDetails.jsx - About 5 hrs to fix

                              Class Comment has 38 methods (exceeds 20 allowed). Consider refactoring.
                              Open

                              class Comment < ApplicationRecord
                                has_ancestry
                                include AlgoliaSearch
                                include Reactable
                                belongs_to :commentable, polymorphic: true
                              Severity: Minor
                              Found in app/models/comment.rb - About 5 hrs to fix

                                Function sendFetch has 103 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                function sendFetch(switchStatement, body) {
                                  switch (switchStatement) {
                                    case 'article-preview':
                                      return function(csrfToken) {
                                        return window.fetch('/articles/preview', {
                                Severity: Major
                                Found in app/assets/javascripts/utilities/sendFetch.js - About 4 hrs to fix

                                  Function render has 103 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    render() {
                                      const {
                                        listings,
                                        orgListings,
                                        userCredits,
                                  Severity: Major
                                  Found in app/javascript/listings/listingDashboard.jsx - About 4 hrs to fix

                                    Class Notification has 32 methods (exceeds 20 allowed). Consider refactoring.
                                    Open

                                    class Notification < ApplicationRecord
                                      belongs_to :notifiable, polymorphic: true
                                      belongs_to :user, optional: true
                                      belongs_to :organization, optional: true
                                    
                                    
                                    Severity: Minor
                                    Found in app/models/notification.rb - About 4 hrs to fix

                                      Function render has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                        render() {
                                          const detectIOSSafariClass =
                                            navigator.userAgent.match(/iPhone/i) &&
                                            !navigator.userAgent.match('CriOS')
                                              ? ' chat--iossafari'
                                      Severity: Major
                                      Found in app/javascript/chat/chat.jsx - About 3 hrs to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language