Sign upLogin

therebelrobot/google-adwords

View on GitHub
Star

Showing 8 of 8 total issues

Function GoogleAdwords has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

var GoogleAdwords = function (spec, my) {
  my = my || {}
  spec = spec || {}

  var self = this
Severity: Minor
Found in lib/googleadwords.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GoogleAdwords has 204 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var GoogleAdwords = function (spec, my) {
  my = my || {}
  spec = spec || {}

  var self = this
Severity: Major
Found in lib/googleadwords.js - About 1 day to fix

    Function _sendAWQL has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var _sendAWQL = function () {
    return new BBPromise(function (resolve, reject) {
      var finalAWQL = _.cloneDeep(my.awqlOptions)
      if (_.isObject(finalAWQL)) {
        finalAWQL =
    Severity: Minor
    Found in lib/googleadwords.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        var _selectStatement = function (rows) {
    if (_.isArray(rows)) {
      rows = rows.join(',')
    }
    my.awqlOptions.select = rows
      Severity: Major
      Found in lib/googleadwords.js and 1 other location - About 1 hr to fix
      lib/googleadwords.js on lines 83..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        var _duringStatement = function (timeframe) {
    if (_.isArray(timeframe)) {
      timeframe = timeframe.join(',')
    }
    my.awqlOptions.during = timeframe
      Severity: Major
      Found in lib/googleadwords.js and 1 other location - About 1 hr to fix
      lib/googleadwords.js on lines 45..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _parseResults has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var _parseResults = function (body) {
    var _finalObj = {}
    var bodyArray = body.split('\n')
    bodyArray.pop()
    var title = bodyArray[0].split('"').join('')
      Severity: Minor
      Found in lib/googleadwords.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (_.isArray(my.awqlOptions.during)) {
        my.awqlOptions.during = my.awqlOptions.during.join(',')
      }
        Severity: Minor
        Found in lib/googleadwords.js and 1 other location - About 55 mins to fix
        lib/googleadwords.js on lines 238..240

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (_.isArray(my.awqlOptions.select)) {
        my.awqlOptions.select = my.awqlOptions.select.join(',')
      }
        Severity: Minor
        Found in lib/googleadwords.js and 1 other location - About 55 mins to fix
        lib/googleadwords.js on lines 241..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language