thestrukture/IDE

View on GitHub

Showing 44 of 1,416 total issues

Avoid deeply nested control flow statements.
Open

    } else if r.FormValue("type") == "3" {
        //pkg
        if r.FormValue("conf") != "do" {
            response = templates.Delete(types.DForm{Text: "Are you sure you want to delete the package " + r.FormValue("pkg"), Link: "type=3&pkg=" + r.FormValue("pkg")})

Severity: Major
Found in api/handlers/rest_POSTApiDelete.go - About 45 mins to fix

    Function ApiTerminal_realtime has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func ApiTerminal_realtime(w http.ResponseWriter, r *http.Request, session *sessions.Session) (response string, callmet bool) {
    
        c, err := globals.Upgrader.Upgrade(w, r, nil)
        if err != nil {
            log.Print("upgrade:", err)
    Severity: Minor
    Found in api/handlers/rest_ApiTerminal_realtime.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                    if globals.Windows {
                                        mjk = strings.Replace(mjk, "/", "\\", -1)
                                    }
    Severity: Major
    Found in api/handlers/middleware_fApiGet.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

          } else if r.FormValue("type") == "4" {
              varf := []types.Inputs{}
              varf = append(varf, types.Inputs{Name: "name", Type: "text", Text: "Template name"})
      
              response = templates.Form(types.Forms{Link: "/api/act?type=5&pkg=" + r.FormValue("pkg") + "&bundle=" + r.FormValue("bundle"), CTA: "Create Template file", Class: "warning", Inputs: varf})
      Severity: Major
      Found in api/handlers/rest_POSTApiCreate.go - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language