thoughtbot/administrate

View on GitHub

Showing 2 of 2 total issues

Class ApplicationController has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ApplicationController < ActionController::Base
    protect_from_forgery with: :exception

    def index
      search_term = params[:search].to_s.strip
Severity: Minor
Found in app/controllers/administrate/application_controller.rb - About 2 hrs to fix

    Method read_param_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def read_param_value(data)
          if data.is_a?(ActionController::Parameters) && data[:type]
            if data[:type] == Administrate::Field::Polymorphic.to_s
              GlobalID::Locator.locate(data[:value])
            else
    Severity: Minor
    Found in app/controllers/administrate/application_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language