thoughtbot/paperclip

View on GitHub

Showing 4 of 999 total issues

Class Attachment has 68 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Attachment
    def self.default_options
      @default_options ||= {
        :convert_options       => {},
        :default_style         => :original,
Severity: Major
Found in lib/paperclip/attachment.rb - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      module Validators
        class AttachmentContentTypeValidator < ActiveModel::EachValidator
          def initialize(options)
            options[:allow_nil] = true unless options.has_key?(:allow_nil)
            super
    lib/paperclip/validators/attachment_file_name_validator.rb on lines 2..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 166.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      module Validators
        class AttachmentFileNameValidator < ActiveModel::EachValidator
          def initialize(options)
            options[:allow_nil] = true unless options.has_key?(:allow_nil)
            super
    Severity: Major
    Found in lib/paperclip/validators/attachment_file_name_validator.rb and 1 other location - About 4 hrs to fix
    lib/paperclip/validators/attachment_content_type_validator.rb on lines 2..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 166.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method extended has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.extended base
            begin
              require 'aws-sdk'
            rescue LoadError => e
              e.message << " (You may need to install the aws-sdk gem)"
    Severity: Major
    Found in lib/paperclip/storage/s3.rb - About 2 hrs to fix
      Severity
      Category
      Status
      Source