threez/ruby-vmstat

View on GitHub

Showing 3 of 5 total issues

Method memory has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def memory
      @pagesize ||= Vmstat.pagesize
      has_available = false

      total = free = active = inactive = pageins = pageouts = available = 0
Severity: Minor
Found in lib/vmstat/procfs.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method memory has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def memory
      @pagesize ||= Vmstat.pagesize
      has_available = false

      total = free = active = inactive = pageins = pageouts = available = 0
Severity: Minor
Found in lib/vmstat/procfs.rb - About 1 hr to fix

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(fs = nil, path = nil, block_size = nil, free_blocks = nil,
                       available_blocks = nil, total_blocks = nil)
    Severity: Minor
    Found in lib/vmstat/linux_disk.rb - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language