Sign upLogin

tibialand/tibia-node-crawler

View on GitHub
Star

Showing 6 of 6 total issues

Function exports has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(body){
  var CharacterParser;

  CharacterParser = new Parser(body)
Severity: Major
Found in src/modules/character/parser.js - About 2 hrs to fix

    Function exports has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(body){
  var WorldParser;

  WorldParser = new Parser(body)
    Severity: Major
    Found in src/modules/world/parser.js - About 2 hrs to fix

      Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {

  grunt.loadNpmTasks('grunt-replace');

  grunt.initConfig({
      Severity: Minor
      Found in Gruntfile.js - About 1 hr to fix

        Function exports has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(body){
  var HighscoresParser;

  HighscoresParser = new Parser(body)
        Severity: Minor
        Found in src/modules/highscores/parser.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Requester.prototype.removeHeader = function(key){
  delete this.headers[key];
  this.headers.splice(1,1);
  return this;
};
          Severity: Major
          Found in src/globals/requester.js and 1 other location - About 1 hr to fix
          src/globals/requester.js on lines 83..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Requester.prototype.removeData = function(key){
  delete this.data[key];
  this.data.splice(1,1);
  return this;
};
          Severity: Major
          Found in src/globals/requester.js and 1 other location - About 1 hr to fix
          src/globals/requester.js on lines 120..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language