timegridio/timegrid

View on GitHub
app/Http/Controllers/API/BookingController.php

Summary

Maintainability
A
1 hr
Test Coverage
A
92%

Method postAction has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function postAction(AlterAppointmentRequest $request)
    {
        logger()->info(__METHOD__);

        //////////////////
Severity: Minor
Found in app/Http/Controllers/API/BookingController.php - About 1 hr to fix

Avoid using static access to class '\Timegridio\Concierge\Models\Appointment' in method 'postAction'.
Open

        $appointment = Appointment::findOrFail($request->input('appointment'));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Timegridio\Concierge\Models\Business' in method 'postAction'.
Open

        $business = Business::findOrFail($request->input('business'));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status