app/Http/Controllers/Manager/ServiceTypeController.php
Avoid using static access to class '\Timegridio\Concierge\Models\ServiceType' in method 'update'. Open
Open
$servicetype = ServiceType::firstOrNew($servicetypeData);- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Multi-line function call not indented correctly; expected 8 spaces but found 12 Open
Open
});- Create a ticketCreate a ticket
- Exclude checks
Closing parenthesis of a multi-line function call must be on a line by itself Open
Open
});- Create a ticketCreate a ticket
- Exclude checks