tmatilai/vagrant-proxyconf

View on GitHub

Showing 15 of 15 total issues

Method update_docker_client_config has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def update_docker_client_config
          return if !supports_config_json? || !docker_client_config_path

          content = File.read(@docker_client_config_path)
          data  = JSON.load(content)
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_docker_client_config has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def update_docker_client_config
          return if !supports_config_json? || !docker_client_config_path

          content = File.read(@docker_client_config_path)
          data  = JSON.load(content)
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 1 hr to fix

    Method skip? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def skip?
              enabled = @machine.config.proxy.enabled
              return true if enabled == false || enabled == ''
              return false if enabled == true
    
    
    Severity: Minor
    Found in lib/vagrant-proxyconf/action/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method disabled? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def disabled?
              enabled = @machine.config.proxy.enabled
              return true if enabled == false || enabled == ''
              return false if enabled == true
    
    
    Severity: Minor
    Found in lib/vagrant-proxyconf/action/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method docker_proxy_conf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

              def self.docker_proxy_conf(machine)
                docker_command = find_docker_command(machine)
                return false if docker_command.nil?
    
                config_path = CONFIG_DIR + docker_command
    Severity: Minor
    Found in lib/vagrant-proxyconf/cap/debian/docker_proxy_conf.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return enabled[app_name][:enabled] == false
    Severity: Major
    Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return enabled[app_name][:skip] == true
      Severity: Major
      Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false if enabled[app_name].has_key?(:skip) == false
        Severity: Major
        Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false if enabled[app_name].has_key?(:skip) == false
          Severity: Major
          Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

            Method load_optional_dependency has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def self.load_optional_dependency(plugin)
                    logger = ProxyConf.logger
                    logger.info "Trying to load #{plugin}"
            
                    if check_vagrant_version('< 1.5.0.dev')
            Severity: Minor
            Found in lib/vagrant-proxyconf/plugin.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method docker_proxy_conf has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                      def self.docker_proxy_conf(machine)
                        docker_command = 'docker'    if Util.which(machine, 'docker')
                        docker_command = 'docker.io' if Util.which(machine, 'docker.io')
            
                        return false if docker_command.nil?
            Severity: Minor
            Found in lib/vagrant-proxyconf/cap/linux/docker_proxy_conf.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    def call(env)
                      @machine = env[:machine]
            
                      if skip?
                        logger.info I18n.t("vagrant_proxyconf.#{config_name}.skip")
            Severity: Minor
            Found in lib/vagrant-proxyconf/action/base.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            module VagrantPlugins
              module ProxyConf
                module Config
                  # Configuration for generic `<protocol>_proxy` environment variables
                  #
            Severity: Minor
            Found in lib/vagrant-proxyconf/config/chef_proxy.rb and 2 other locations - About 15 mins to fix
            lib/vagrant-proxyconf/config/docker_proxy.rb on lines 4..22
            lib/vagrant-proxyconf/config/npm_proxy.rb on lines 4..22

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            module VagrantPlugins
              module ProxyConf
                module Config
                  # Proxy configuration for npm
                  #
            Severity: Minor
            Found in lib/vagrant-proxyconf/config/npm_proxy.rb and 2 other locations - About 15 mins to fix
            lib/vagrant-proxyconf/config/chef_proxy.rb on lines 4..22
            lib/vagrant-proxyconf/config/docker_proxy.rb on lines 4..22

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            module VagrantPlugins
              module ProxyConf
                module Config
                  # Configuration for generic `<protocol>_proxy` environment variables
                  #
            Severity: Minor
            Found in lib/vagrant-proxyconf/config/docker_proxy.rb and 2 other locations - About 15 mins to fix
            lib/vagrant-proxyconf/config/chef_proxy.rb on lines 4..22
            lib/vagrant-proxyconf/config/npm_proxy.rb on lines 4..22

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language