tmatilai/vagrant-proxyconf

View on GitHub

Showing 14 of 17 total issues

Method update_docker_client_config has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def update_docker_client_config
          return if !supports_config_json? || !docker_client_config_path

          content = File.read(@docker_client_config_path)
          data  = JSON.load(content)
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_docker_systemd_config has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        def update_docker_systemd_config
          return if !supports_systemd?
          changed = false

          if disabled?
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_docker_client_config has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def update_docker_client_config
          return if !supports_config_json? || !docker_client_config_path

          content = File.read(@docker_client_config_path)
          data  = JSON.load(content)
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 1 hr to fix

    Method update_docker_systemd_config has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def update_docker_systemd_config
              return if !supports_systemd?
              changed = false
    
              if disabled?
    Severity: Minor
    Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 1 hr to fix

      Method disabled? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def disabled?
                enabled = @machine.config.proxy.enabled
                return true if enabled == false || enabled == ''
                return false if enabled == true
      
      
      Severity: Minor
      Found in lib/vagrant-proxyconf/action/base.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method skip? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def skip?
                enabled = @machine.config.proxy.enabled
                return true if enabled == false || enabled == ''
                return false if enabled == true
      
      
      Severity: Minor
      Found in lib/vagrant-proxyconf/action/base.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method docker_proxy_conf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

                def self.docker_proxy_conf(machine)
                  docker_command = find_docker_command(machine)
                  return false if docker_command.nil?
      
                  config_path = CONFIG_DIR + docker_command
      Severity: Minor
      Found in lib/vagrant-proxyconf/cap/debian/docker_proxy_conf.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return false if enabled[app_name].has_key?(:skip) == false
      Severity: Major
      Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return enabled[app_name][:enabled] == false
        Severity: Major
        Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false if enabled[app_name].has_key?(:skip) == false
          Severity: Major
          Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return enabled[app_name][:skip] == true
            Severity: Major
            Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

              Method docker_proxy_conf has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                        def self.docker_proxy_conf(machine)
                          docker_command = 'docker'    if Util.which(machine, 'docker')
                          docker_command = 'docker.io' if Util.which(machine, 'docker.io')
              
                          return false if docker_command.nil?
              Severity: Minor
              Found in lib/vagrant-proxyconf/cap/linux/docker_proxy_conf.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method load_optional_dependency has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def self.load_optional_dependency(plugin)
                      logger = ProxyConf.logger
                      logger.info "Trying to load #{plugin}"
              
                      if check_vagrant_version('< 1.5.0.dev')
              Severity: Minor
              Found in lib/vagrant-proxyconf/plugin.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def call(env)
                        @machine = env[:machine]
              
                        if skip?
                          logger.info I18n.t("vagrant_proxyconf.#{config_name}.skip")
              Severity: Minor
              Found in lib/vagrant-proxyconf/action/base.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language