Sign upLogin

tmatilai/vagrant-proxyconf

View on GitHub
Star
lib/vagrant-proxyconf/action/configure_docker_proxy.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method update_docker_client_config has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        def update_docker_client_config
          return if !supports_config_json? || !docker_client_config

          content = File.read(@docker_client_config)
          data  = JSON.load(content)
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_docker_systemd_config has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        def update_docker_systemd_config
          return if !supports_systemd?
          changed = false

          if disabled?
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_docker_systemd_config has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def update_docker_systemd_config
          return if !supports_systemd?
          changed = false

          if disabled?
Severity: Minor
Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 1 hr to fix

    Method update_docker_client_config has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def update_docker_client_config
          return if !supports_config_json? || !docker_client_config

          content = File.read(@docker_client_config)
          data  = JSON.load(content)
    Severity: Minor
    Found in lib/vagrant-proxyconf/action/configure_docker_proxy.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status