Sign upLogin

tom-weatherhead/thaw-grammar

View on GitHub
Star
src/languages/clu/domain-object-model/operator-usage.ts

Summary

Maintainability
D
2 days
Test Coverage

Function evaluate has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    public evaluate(
        globalInfo: IGlobalInfo<ICLUValue>,
        localEnvironment?: IEnvironmentFrame<ICLUValue>,
        options?: unknown
    ): ICLUValue {
Severity: Minor
Found in src/languages/clu/domain-object-model/operator-usage.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function evaluate has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public evaluate(
        globalInfo: IGlobalInfo<ICLUValue>,
        localEnvironment?: IEnvironmentFrame<ICLUValue>,
        options?: unknown
    ): ICLUValue {
Severity: Major
Found in src/languages/clu/domain-object-model/operator-usage.ts - About 3 hrs to fix

    Function evaluateNormal has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected evaluateNormal(
        funDef: CLUNormalFunctionDefinition | undefined,
        evaluatedArguments: ICLUValue[],
        cluster: ICluster | undefined,
        globalInfo: IGlobalInfo<ICLUValue>
    Severity: Minor
    Found in src/languages/clu/domain-object-model/operator-usage.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File operator-usage.ts has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // clu/domain-object-model/operator-usage.ts

// import { ArgumentException } from 'thaw-interpreter-core';

import {
    Severity: Minor
    Found in src/languages/clu/domain-object-model/operator-usage.ts - About 2 hrs to fix

      Function evaluateNormal has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected evaluateNormal(
        funDef: CLUNormalFunctionDefinition | undefined,
        evaluatedArguments: ICLUValue[],
        cluster: ICluster | undefined,
        globalInfo: IGlobalInfo<ICLUValue>
      Severity: Minor
      Found in src/languages/clu/domain-object-model/operator-usage.ts - About 1 hr to fix

        Function tryGetExpectedNumArgs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected tryGetExpectedNumArgs(
        funDef: CLUFunctionDefinitionBase | undefined,
        cluster: ICluster | undefined,
        // eslint-disable-next-line @typescript-eslint/no-unused-vars
        globalInfo: IGlobalInfo<ICLUValue>
        Severity: Minor
        Found in src/languages/clu/domain-object-model/operator-usage.ts - About 1 hr to fix

          Function tryGetExpectedNumArgs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              protected tryGetExpectedNumArgs(
        funDef: CLUFunctionDefinitionBase | undefined,
        cluster: ICluster | undefined,
        // eslint-disable-next-line @typescript-eslint/no-unused-vars
        globalInfo: IGlobalInfo<ICLUValue>
          Severity: Minor
          Found in src/languages/clu/domain-object-model/operator-usage.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkArgTypes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              protected checkArgTypes(
        funDef: CLUFunctionDefinitionBase | undefined,
        cluster: ICluster | undefined,
        evaluatedArguments: ICLUValue[]
    ): void {
          Severity: Minor
          Found in src/languages/clu/domain-object-model/operator-usage.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                          if (!globalInfo.functionDefinitions.has(this.functionName)) {
                    throw new Error(
                        `CLUOperatorUsage.evaluate() : Unknown global function '${this.functionName}'.`
                    );
                }
          Severity: Major
          Found in src/languages/clu/domain-object-model/operator-usage.ts - About 45 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    const secondArgAsInt =
            evaluatedArguments.length > 1 && globalInfo.valueIsInteger(evaluatedArguments[1])
                ? globalInfo.valueAsInteger(evaluatedArguments[1])
                : 0;
            Severity: Major
            Found in src/languages/clu/domain-object-model/operator-usage.ts and 3 other locations - About 40 mins to fix
            src/common/domain-object-model/operator-usage.ts on lines 176..179
            src/common/domain-object-model/operator-usage.ts on lines 180..183
            src/languages/clu/domain-object-model/operator-usage.ts on lines 182..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    const firstArgAsInt =
            evaluatedArguments.length > 0 && globalInfo.valueIsInteger(evaluatedArguments[0])
                ? globalInfo.valueAsInteger(evaluatedArguments[0])
                : 0;
            Severity: Major
            Found in src/languages/clu/domain-object-model/operator-usage.ts and 3 other locations - About 40 mins to fix
            src/common/domain-object-model/operator-usage.ts on lines 176..179
            src/common/domain-object-model/operator-usage.ts on lines 180..183
            src/languages/clu/domain-object-model/operator-usage.ts on lines 186..189

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status