tomchentw/react-prop-types-element-of-type

View on GitHub

Showing 4 of 16 total issues

Function describePropTypesElementOfType has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

describe(`propTypesElementOfType`, function describePropTypesElementOfType() {
  let domEl;
  let ChildComponent;
  let WrapperComponent;
  let consoleErrorSpy;
Severity: Major
Found in src/__tests__/index.spec.js - About 2 hrs to fix

    Function createComponentTypeChecker has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function createComponentTypeChecker(expectedComponent) {
      function validate(isRequired, props, propName, componentName, location, propFullName = propName) {
        const locationName = ReactPropTypeLocationNames[location];
        if (props[propName] === null || props[propName] === undefined) {
          if (isRequired) {
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function createComponentTypeChecker has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function createComponentTypeChecker(expectedComponent) {
        function validate(isRequired, props, propName, componentName, location, propFullName = propName) {
          const locationName = ReactPropTypeLocationNames[location];
          if (props[propName] === null || props[propName] === undefined) {
            if (isRequired) {
      Severity: Minor
      Found in src/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        function validate(isRequired, props, propName, componentName, location, propFullName = propName) {
      Severity: Minor
      Found in src/index.js - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language