tomopy/tomopy

View on GitHub
benchmarking/rec.py

Summary

Maintainability
C
1 day
Test Coverage

File rec.py has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

"""
TomoPy script to reconstruct a TomoBank file
Severity: Minor
Found in benchmarking/rec.py - About 3 hrs to fix

    Function main has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def main(arg):
    
        import multiprocessing as mp
        default_ncores = mp.cpu_count()
        default_type = "partial"
    Severity: Minor
    Found in benchmarking/rec.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def main(arg):
    
        import multiprocessing as mp
        default_ncores = mp.cpu_count()
        default_type = "partial"
    Severity: Minor
    Found in benchmarking/rec.py - About 1 hr to fix

      Function reconstruct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def reconstruct(h5fname, sino, rot_center, args, blocked_views=None):
      
          # Read APS 32-BM raw data.
          proj, flat, dark, theta = dxchange.read_aps_32id(h5fname, sino=sino)
      
      
      Severity: Minor
      Found in benchmarking/rec.py - About 1 hr to fix

        Function reconstruct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def reconstruct(h5fname, sino, rot_center, args, blocked_views=None):
        Severity: Minor
        Found in benchmarking/rec.py - About 35 mins to fix

          Function rec_full has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def rec_full(h5fname, rot_center, args, blocked_views, nchunks=16):
          Severity: Minor
          Found in benchmarking/rec.py - About 35 mins to fix

            Function rec_partial has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def rec_partial(h5fname, rot_center, args, blocked_views, nchunks=1):
            Severity: Minor
            Found in benchmarking/rec.py - About 35 mins to fix

              Function rec_slice has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def rec_slice(h5fname, nsino, rot_center, args, blocked_views):
              Severity: Minor
              Found in benchmarking/rec.py - About 35 mins to fix

                Function rec_partial has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def rec_partial(h5fname, rot_center, args, blocked_views, nchunks=1):
                
                    data_size = get_dx_dims(h5fname, 'data')
                    print("data size: {}".format(data_size))
                
                
                Severity: Minor
                Found in benchmarking/rec.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status