tomopy/tomopy

View on GitHub
source/tomopy/misc/benchmark.py

Summary

Maintainability
C
1 day
Test Coverage

File benchmark.py has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

# #########################################################################
# Copyright (c) 2015, UChicago Argonne, LLC. All rights reserved.         #
Severity: Minor
Found in source/tomopy/misc/benchmark.py - About 2 hrs to fix

    Function output_images has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def output_images(rec, fpath, format="jpeg", scale=1, ncol=1):
        """Save an image stack as a series of concatenated images.
    
        Each set of ncol images are concatenated horizontally and saved together
        into files named {fpath}_0_{ncol}.{img_format},
    Severity: Minor
    Found in source/tomopy/misc/benchmark.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, ncompare, nslice, nrows, ncols, solution=None, dtype=float):
    Severity: Minor
    Found in source/tomopy/misc/benchmark.py - About 45 mins to fix

      Function output_images has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def output_images(rec, fpath, format="jpeg", scale=1, ncol=1):
      Severity: Minor
      Found in source/tomopy/misc/benchmark.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            print("Image size: {} x {} x {}".format(
                rec[0].shape[0],
                rec[0].shape[1],
                rec.shape[0]))
        Severity: Major
        Found in source/tomopy/misc/benchmark.py and 1 other location - About 1 hr to fix
        source/tomopy/misc/benchmark.py on lines 307..310

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            print("Scaled Image size: {} x {} x {}".format(
                rec_n[0].shape[0],
                rec_n[0].shape[1],
                rec_n.shape[0]))
        Severity: Major
        Found in source/tomopy/misc/benchmark.py and 1 other location - About 1 hr to fix
        source/tomopy/misc/benchmark.py on lines 302..305

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            _sx = ndimage.sobel(_img, axis=0, mode='reflect') - \
                ndimage.sobel(_rec, axis=0, mode='reflect')
        Severity: Minor
        Found in source/tomopy/misc/benchmark.py and 1 other location - About 55 mins to fix
        source/tomopy/misc/benchmark.py on lines 259..260

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            _sy = ndimage.sobel(_img, axis=1, mode='reflect') - \
                ndimage.sobel(_rec, axis=1, mode='reflect')
        Severity: Minor
        Found in source/tomopy/misc/benchmark.py and 1 other location - About 55 mins to fix
        source/tomopy/misc/benchmark.py on lines 256..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status