tomopy/tomopy

View on GitHub
source/tomopy/misc/phantom.py

Summary

Maintainability
F
5 days
Test Coverage

File phantom.py has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

# #########################################################################
# Copyright (c) 2015-2019, UChicago Argonne, LLC. All rights reserved.    #
Severity: Minor
Found in source/tomopy/misc/phantom.py - About 4 hrs to fix

    Function _ellipsoid has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def _ellipsoid(params, shape=None, out=None, coords=None):
        """
        Generate a cube containing an ellipsoid defined by its parameters.
        If out is given, fills the given cube instead of creating a new one.
        """
    Severity: Minor
    Found in source/tomopy/misc/phantom.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def barbara(size=512, dtype='float32'):
        """
        Load test Barbara image array.
    
        Parameters
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 5 other locations - About 5 hrs to fix
    source/tomopy/misc/phantom.py on lines 145..168
    source/tomopy/misc/phantom.py on lines 171..194
    source/tomopy/misc/phantom.py on lines 197..220
    source/tomopy/misc/phantom.py on lines 223..246
    source/tomopy/misc/phantom.py on lines 249..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def cameraman(size=512, dtype='float32'):
        """
        Load test cameraman image array.
    
        Parameters
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 5 other locations - About 5 hrs to fix
    source/tomopy/misc/phantom.py on lines 119..142
    source/tomopy/misc/phantom.py on lines 171..194
    source/tomopy/misc/phantom.py on lines 197..220
    source/tomopy/misc/phantom.py on lines 223..246
    source/tomopy/misc/phantom.py on lines 249..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def lena(size=512, dtype='float32'):
        """
        Load test Lena image array.
    
        Parameters
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 5 other locations - About 5 hrs to fix
    source/tomopy/misc/phantom.py on lines 119..142
    source/tomopy/misc/phantom.py on lines 145..168
    source/tomopy/misc/phantom.py on lines 171..194
    source/tomopy/misc/phantom.py on lines 223..246
    source/tomopy/misc/phantom.py on lines 249..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def peppers(size=512, dtype='float32'):
        """
        Load test peppers image array.
    
        Parameters
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 5 other locations - About 5 hrs to fix
    source/tomopy/misc/phantom.py on lines 119..142
    source/tomopy/misc/phantom.py on lines 145..168
    source/tomopy/misc/phantom.py on lines 171..194
    source/tomopy/misc/phantom.py on lines 197..220
    source/tomopy/misc/phantom.py on lines 249..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def checkerboard(size=512, dtype='float32'):
        """
        Load test checkerboard image array.
    
        Parameters
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 5 other locations - About 5 hrs to fix
    source/tomopy/misc/phantom.py on lines 119..142
    source/tomopy/misc/phantom.py on lines 145..168
    source/tomopy/misc/phantom.py on lines 197..220
    source/tomopy/misc/phantom.py on lines 223..246
    source/tomopy/misc/phantom.py on lines 249..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def shepp2d(size=512, dtype='float32'):
        """
        Load test Shepp-Logan image array.
    
        Parameters
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 5 other locations - About 5 hrs to fix
    source/tomopy/misc/phantom.py on lines 119..142
    source/tomopy/misc/phantom.py on lines 145..168
    source/tomopy/misc/phantom.py on lines 171..194
    source/tomopy/misc/phantom.py on lines 197..220
    source/tomopy/misc/phantom.py on lines 223..246

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        M0 = np.array([p['x0'], p['y0'], p['z0']], dtype=_dt).reshape(_shape)
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 1 other location - About 1 hr to fix
    source/tomopy/misc/phantom.py on lines 415..415

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        sc = np.array([p['a'], p['b'], p['c']], dtype=_dt).reshape(_shape)
    Severity: Major
    Found in source/tomopy/misc/phantom.py and 1 other location - About 1 hr to fix
    source/tomopy/misc/phantom.py on lines 414..414

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status