Sign upLogin

tomopy/tomopy

View on GitHub
Star
source/tomopy/recon/algorithm.py

Summary

Maintainability
D
2 days
Test Coverage

Function recon has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

def recon(tomo,
          theta,
          center=None,
          sinogram_order=False,
          algorithm=None,
Severity: Minor
Found in source/tomopy/recon/algorithm.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _dist_recon has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

def _dist_recon(tomo, center, recon, algorithm, args, kwargs, ncore, nchunk):
    axis_size = recon.shape[0]
    ncore, slcs = mproc.get_ncore_slices(axis_size, ncore, nchunk)

    if len(slcs) < ncore:
Severity: Minor
Found in source/tomopy/recon/algorithm.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File algorithm.py has 360 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

# #########################################################################
# Copyright (c) 2015-2019, UChicago Argonne, LLC. All rights reserved.    #
Severity: Minor
Found in source/tomopy/recon/algorithm.py - About 4 hrs to fix

    Function _init_recon has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def _init_recon(shape, init_recon, val=1e-6, sharedmem=True, empty=False):
    if init_recon is None:
        if sharedmem:
            recon = dtype.empty_shared_array(shape)
            recon[:] = val
    Severity: Minor
    Found in source/tomopy/recon/algorithm.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function recon has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def recon(tomo,
    Severity: Major
    Found in source/tomopy/recon/algorithm.py - About 1 hr to fix

      Function _dist_recon has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _dist_recon(tomo, center, recon, algorithm, args, kwargs, ncore, nchunk):
      Severity: Major
      Found in source/tomopy/recon/algorithm.py - About 1 hr to fix

        Function _run_accel_algorithm has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _run_accel_algorithm(idx, _func, tomo, center, recon, *_args, **_kwargs):
        Severity: Major
        Found in source/tomopy/recon/algorithm.py - About 50 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if not isinstance(kwargs[key], np.float32):
                        kwargs[key] = np.array(value, dtype='float32')

        # Set kwarg defaults.
        for kw in allowed_kwargs[algorithm]:
          Severity: Major
          Found in source/tomopy/recon/algorithm.py - About 45 mins to fix

            Function _init_recon has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _init_recon(shape, init_recon, val=1e-6, sharedmem=True, empty=False):
            Severity: Minor
            Found in source/tomopy/recon/algorithm.py - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if tomo.shape[1] != len(theta):
        msg = 'There must be one angle for every projection.'
        raise ValueError(msg)
              Severity: Minor
              Found in source/tomopy/recon/algorithm.py and 1 other location - About 40 mins to fix
              source/tomopy/recon/algorithm.py on lines 318..320

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if tomo.shape[0] != len(center_arr):
        msg = 'There must be one center for every slice.'
        raise ValueError(msg)
              Severity: Minor
              Found in source/tomopy/recon/algorithm.py and 1 other location - About 40 mins to fix
              source/tomopy/recon/algorithm.py on lines 265..267

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if algorithm not in allowed_kwargs:
            raise ValueError(
                'Keyword "algorithm" must be one of %s, or a Python method.' %
                (list(allowed_kwargs.keys()), ))
              Severity: Minor
              Found in source/tomopy/recon/algorithm.py and 1 other location - About 35 mins to fix
              source/tomopy/recon/acceleration.py on lines 159..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status