Sign upLogin

tomopy/tomopy

View on GitHub
Star
source/tomopy/recon/vector.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function vector3 has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

def vector3(tomo1, tomo2, tomo3, theta1, theta2, theta3, center1=None, center2=None, center3=None, num_iter=1, axis1=0, axis2=1, axis3=2):
Severity: Major
Found in source/tomopy/recon/vector.py - About 1 hr to fix

    Function vector2 has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def vector2(tomo1, tomo2, theta1, theta2, center1=None, center2=None, num_iter=1, axis1=1, axis2=2):
    Severity: Major
    Found in source/tomopy/recon/vector.py - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          recon_shape = (tomo1.shape[0], tomo1.shape[2], tomo1.shape[2])
      Severity: Minor
      Found in source/tomopy/recon/vector.py and 2 other locations - About 35 mins to fix
      source/tomopy/recon/vector.py on lines 79..79
      source/tomopy/recon/vector.py on lines 126..126

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          recon_shape = (tomo1.shape[0], tomo1.shape[2], tomo1.shape[2])
      Severity: Minor
      Found in source/tomopy/recon/vector.py and 2 other locations - About 35 mins to fix
      source/tomopy/recon/vector.py on lines 79..79
      source/tomopy/recon/vector.py on lines 100..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          recon_shape = (tomo.shape[0], tomo.shape[2], tomo.shape[2])
      Severity: Minor
      Found in source/tomopy/recon/vector.py and 2 other locations - About 35 mins to fix
      source/tomopy/recon/vector.py on lines 100..100
      source/tomopy/recon/vector.py on lines 126..126

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status